Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Aggregators'
drop_original = true
doesn't work well with*_consumer
inputs'max_undelivered_messages
. (mentioned by me at #5595 (comment))*_consumer
inputs are usingAddTrackingMetricGroup
to find out whether metrics get delivered (eitherAccept
orDrop
,Reject
won't count). However, whendrop_original = true
, metrics are dropped without callingmetric.Drop()
. As a result, inputs lost track of metrics, consider dropped metrics undelivered, andmax_undelivered_messages
is reached rather quickly. Eventually,*_consumer
inputs stop consuming new messages.Required for all PRs: