Set socket permissions for unix domain sockets #5760
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Defaults to world-writable by default (777) * New configuration option file_mode allows for custom permissions
…mg-3239-socket-permission
…r/telegraf into gentstr-mg-3239-socket-permission
danielnelson
added
the
feat
|
@gentstr Can you review? |
glinton
approved these changes
Apr 25, 2019
| @@ -25,6 +25,13 @@ This is a sample configuration for the plugin. | |||
| # service_address = "unix:///tmp/telegraf.sock" | |||
| # service_address = "unixgram:///tmp/telegraf.sock" | |||
|
|
|||
| ## Change the file mode bits on unix sockets. These permissions may not be | |||
| ## repected by some platforms, to safely restrict write permissions it is best | |||
3 tasks
hwaastad
pushed a commit
to hwaastad/telegraf
that referenced
this pull request
Jun 13, 2019
bitcharmer
pushed a commit
to bitcharmer/telegraf
that referenced
this pull request
Oct 18, 2019
athoune
pushed a commit
to bearstech/telegraf
that referenced
this pull request
Apr 17, 2020
idohalevi
pushed a commit
to idohalevi/telegraf
that referenced
this pull request
Sep 29, 2020
|
This either should be merged with syslog plugin, or this issue should be addressed. As syslog plugin currently lacks the ability to set proper ownership and mode. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continuation of the work on #3996.
Renamed the option to socket_mode to match the name in pdns_recursor and only set the mode if set in the configuration file so by default we honor the umask.
closes #3239
Required for all PRs: