Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support passive queue declaration in amqp_consumer #5831

Merged
merged 4 commits into from
May 20, 2019

Conversation

danielnelson
Copy link
Contributor

Required for all PRs:

  • Signed CLA.
  • Associated README.md updated.
  • Has appropriate unit tests.

@danielnelson danielnelson added feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin area/rabbitmq labels May 10, 2019
@danielnelson danielnelson added this to the 1.11.0 milestone May 10, 2019
@Esity
Copy link

Esity commented May 16, 2019

So this works for passive queues but it still requires an exchange name to be specified. If I don't and the AMQP creds don't have permission to create an exchange you will get this message

`2019-05-16T17:57:48Z E! [agent] Service for input inputs.amqp_consumer failed to start: error declaring exchange: Exception (403) Reason: "ACCESS_REFUSED - operation not permitted on the default exchange"

2019-05-16T17:57:48Z E! [telegraf] Error running agent: error declaring exchange: Exception (403) Reason: "ACCESS_REFUSED - operation not permitted on the default exchange"`

@danielnelson

@danielnelson
Copy link
Contributor Author

I've updated the plugin to skip exchange declaration when it is set to "", as otherwise it seems to be impossible to use the default exchange and anyway it really should be optional. Similar for bindings, they are now only created when set to a non empty string.

@danielnelson danielnelson merged commit e141518 into master May 20, 2019
@danielnelson danielnelson deleted the amqp-passive-queue branch May 20, 2019 21:38
hwaastad pushed a commit to hwaastad/telegraf that referenced this pull request Jun 13, 2019
bitcharmer pushed a commit to bitcharmer/telegraf that referenced this pull request Oct 18, 2019
athoune pushed a commit to bearstech/telegraf that referenced this pull request Apr 17, 2020
idohalevi pushed a commit to idohalevi/telegraf that referenced this pull request Sep 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/rabbitmq feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants