Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Made the SMART timeout a parameter, and set the default to 30s #6241

Merged
merged 3 commits into from
Aug 13, 2019
Merged

Made the SMART timeout a parameter, and set the default to 30s #6241

merged 3 commits into from
Aug 13, 2019

Conversation

marcv81
Copy link
Contributor

@marcv81 marcv81 commented Aug 12, 2019

Fix for #6240.

This change makes the SMART timeout a configuration parameter, and bumps the default value from 5s to 30s.

  • Previous behavior: measurements are dropped when the HDD is under heavy load.
  • Current behavior: measurements are delayed (5-10s on my system) but not dropped.

Required for all PRs:

  • Signed CLA.
  • Associated README.md updated.
  • Has appropriate unit tests.

This provides an out-of-the box experience with modern HDDs.
@danielnelson danielnelson added this to the 1.12.0 milestone Aug 12, 2019
@danielnelson danielnelson added feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin area/smart labels Aug 12, 2019
@danielnelson danielnelson merged commit 5473872 into influxdata:master Aug 13, 2019
bitcharmer pushed a commit to bitcharmer/telegraf that referenced this pull request Oct 18, 2019
athoune pushed a commit to bearstech/telegraf that referenced this pull request Apr 17, 2020
idohalevi pushed a commit to idohalevi/telegraf that referenced this pull request Sep 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/smart feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants