Record Device Fields Regardless of Attribute Flag #6638
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
set attributes flag to true. With attributes set to false, if the metric is classified as an attribute it is not recorded. This occurs even is the metric is not a vendor attribute. Left it like this to keep the system compatible with users who are expecting the current structure.
|
Not sure why test-go-1.12 is failing for an unrelated plug-in. Any tips would be appreciated. For clarity, this PR handles #6619 |
|
@ryan-peck Sorry, just an intermittent test, I think it was resolved in 25e1636. Are you able to sign the CLA so I can review? |
|
Thanks for the update! I have just signed the CLA. |
danielnelson
approved these changes
Jan 15, 2020
athoune
pushed a commit
to bearstech/telegraf
that referenced
this pull request
Apr 17, 2020
idohalevi
pushed a commit
to idohalevi/telegraf
that referenced
this pull request
Sep 29, 2020
arstercz
pushed a commit
to arstercz/telegraf
that referenced
this pull request
Mar 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed logic to allow recording of device fields without having to set attributes flag to true. With attributes set to false, if the metric is classified as an attribute it is not recorded. This occurs even is the metric is not a vendor attribute. Left it like this to keep the system compatible with users who are expecting the current structure. Validated with 'go test' and by building telegraf and monitoring inputs into local influxdb.
closes #6619
Required for all PRs: