Lustre2 plugin #86
Merged
Lustre2 plugin #86
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The configuration allows users to override the /proc/ files scanned for data, since that has been known to change with lustre versions.
|
Oh, one other remark: it uses ReadLines from system/ps/common/, to avoid code duplication. I'm unsure if that would be considered safe behaviour. It's tempting to move those common plugin utilities up a level for use across all plugins. |
srfraser
force-pushed
the
lustre2-plugin
branch
from
1dd560c
to
d09e5f3
Compare
|
Thanks for the contribution! Don't worry about the ReadLines piece, I will be refactoring all of that code to just use the external gopsutil library anyways |
|
@srfraser I can merge this once you've fixed the branch conflicts |
…stre2-plugin Conflicts: testutil/accumulator.go
|
@sparrc Done - thank you! |
srfraser
pushed a commit
to srfraser/telegraf
that referenced
this pull request
Aug 10, 2015
Lustre2 plugin
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Lustre is a high performance cluster filesystem (http://lustre.org), used in HPC environments. Usefully, it makes data available in /proc, so here is a plugin to read those /proc files.
Lustre 2.x stores them in a different location to Lustre 1.x, hence the versioned plugin information. The configuration file allows those locations to be overridden for future proofing, and to make testing easier.
One modification that may be necessary until cross-measurement mathematics is enabled is to store read_bytes and read_calls (and write_*) in the same measurement to get mean bytes per call metrics.