faraday-async limit iovecs to iovec max #75
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sh on large iops)" This reverts commit 2bfb9bc.
|
The httpaf example code that I used to reproduce and debug this can be found here: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I discovered that when using faraday-async while trying to serve large files with httpaf, the writev() syscall would fail with EINVAL because iovcnt was greater than IOV_MAX on my system (Linux).
Lwt works just fine without this patch because [Lwt_unix.writev] does this automatically while [Bigstring_unix.writev] which ultimately gets called on the Async side is more naive and defaults to just slamming whatever iovecs array you give it into writev().
I tried calling [Bigstring_unx.writev] with the optional count argument but that didn't seem to work while this patch did.
A better solution might be to patch [Bigstring_unix.writev] to be smarter about this mirroring the Lwt approach.