-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
For legacy browsers (without modules) #309
Comments
I checked and that file is an es6 module, doh. How are you trying to import countup? |
Just as in 1997 like ;)
Without any kind of module import |
Since it's a module, it doesn't expose a global so won't work like using
scripts in the 90's. I should probably fix that and package it up as UMD if
that works.
…On Thu, Apr 20, 2023 at 7:10 AM clarkk ***@***.***> wrote:
Just as in the 90'es like
<script src="/js/github/inorganik/countUp.js/countUp.withPolyfill.min.js" defer></script>
Without any kind of module import
—
Reply to this email directly, view it on GitHub
<#309 (comment)>,
or unsubscribe
<https:/notifications/unsubscribe-auth/AAA2X4KPKJDPPECAKIDKSFDXCEYVDANCNFSM6AAAAAAXFGPU3I>
.
You are receiving this because you commented.Message ID:
***@***.***>
|
Lookinng forward to a fix. Browsers without ES6 support is still around |
@clarkk Please try using |
I just use umd without module and it works fine
|
Great! Here's what the dist folder will look like after my change in #311
so you'll just need to include the umd file and polyfill separately. |
This was merged and released in v2.6.1. |
When I try to use the legacy version without modules I get an error
Error
Chrome Version 112.0.5615.86 (Officiel version) (64-bit)
The text was updated successfully, but these errors were encountered: