Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(YouTube Music/Navigation bar components): do not use hardcoded color values ​​when Enable black navigation bar setting is turned off #2440

Open
5 tasks done
innuendofloyd opened this issue Oct 18, 2024 · 6 comments
Labels
Suggestion Leave any other suggestions

Comments

@innuendofloyd
Copy link

Application

YouTube Music

Feature description

Hello, my eyes really hurt when I read white fonts on a amoled/black background, so I usually theme color.xml. The recent Navbar patch overwrite my (kinda) theme. Even if I disable black Navbar it stays greysh.
I kindly request to allow the choice of Navbar color, in options file maybe?
NEW
OLD

Thank you.

Motivation

I know it could be "ad personam" request, I just like the UI to be neat with the color I chose.
My eyes are thankful with #FF5b513f , so I don't see white fonts in the sky for an half hour after I used the app.
Thank you anyway

Acknowledgements

  • This is not a feature request for YouTube.
  • This issue is not a duplicate of an existing feature request.
  • I have chosen an appropriate title.
  • All requested information has been provided properly.
  • I have written the title and contents in English.
@innuendofloyd innuendofloyd added the Feature request Requesting a new feature label Oct 18, 2024
@inotia00
Copy link
Owner

please add the color name of the colors.xml you modified

(e.g. "yt_black0", "yt_black1", ...)

@inotia00 inotia00 changed the title feat: Navbar Theme feat(YouTube Music/Amoled): add patch options Oct 18, 2024
@innuendofloyd
Copy link
Author

Since I'm a butcher and not a developer I basically changed every black or dark color in colors.xml
colors.zip

@inotia00
Copy link
Owner

inotia00 commented Oct 18, 2024

In this case, it would be difficult to implement with a standardized patch

@innuendofloyd
Copy link
Author

I don't demand a total theme for the entire app. Maybe could it be possible to separate the black navbar code from the navbar patch?
My point is I need it just to hide "sample" and "upgrade to premium"
Moreover, could I exclude navbar patch totally, and hide "sample" and "premium" in another way?

@inotia00
Copy link
Owner

It's hard to separate only the Enable black navigation bar patch from the Navigation bar components patch

Instead, I can make it use the color defined in colors.xml (@color/ytm_color_grey_12) instead of the hardcoded color when the Enable black navigation bar setting is off

@innuendofloyd
Copy link
Author

Yes!! Thank you!!

@inotia00 inotia00 changed the title feat(YouTube Music/Amoled): add patch options feat(YouTube Music/Navigation bar components): do not use hardcoded color values ​​when Enable black navigation bar setting is turned off Oct 19, 2024
@inotia00 inotia00 added Suggestion Leave any other suggestions and removed Feature request Requesting a new feature labels Oct 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Suggestion Leave any other suggestions
Projects
None yet
Development

No branches or pull requests

2 participants