-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(YouTube Music/Navigation bar components): do not use hardcoded color values when Enable black navigation bar
setting is turned off
#2440
Comments
please add the color name of the colors.xml you modified (e.g. "yt_black0", "yt_black1", ...) |
Since I'm a butcher and not a developer I basically changed every black or dark color in colors.xml |
In this case, it would be difficult to implement with a standardized patch |
I don't demand a total theme for the entire app. Maybe could it be possible to separate the black navbar code from the navbar patch? |
It's hard to separate only the Instead, I can make it use the color defined in colors.xml (@color/ytm_color_grey_12) instead of the hardcoded color when the |
Yes!! Thank you!! |
Enable black navigation bar
setting is turned off
Application
YouTube Music
Feature description
Hello, my eyes really hurt when I read white fonts on a amoled/black background, so I usually theme color.xml. The recent Navbar patch overwrite my (kinda) theme. Even if I disable black Navbar it stays greysh.
I kindly request to allow the choice of Navbar color, in options file maybe?
Thank you.
Motivation
I know it could be "ad personam" request, I just like the UI to be neat with the color I chose.
My eyes are thankful with #FF5b513f , so I don't see white fonts in the sky for an half hour after I used the app.
Thank you anyway
Acknowledgements
The text was updated successfully, but these errors were encountered: