This repository has been archived by the owner on Jul 5, 2023. It is now read-only.
Cleanup runner image #106
Merged
Cleanup runner image #106
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maxbischoff
suggested changes
Aug 3, 2020
There was a problem hiding this comment.
If I'm not mistaken, https:/inovex/illuminatio/pull/106/files#diff-04c6e90faac2675aa89e2176d2eec7d8R171 will not work after this change anymore. Instead /usr/local/bin/illuminatio needs to be specified as new CMD.
Otherwise LGTM, thanks for your contribution 👍
|
The provided links doesn't work but I assume you wanted to reference the |
johscheuer
force-pushed
the
cleanup-runner-image
branch
from
2a9c569
to
e80f091
Compare
Codecov Report
@@ Coverage Diff @@
## master #106 +/- ##
=======================================
Coverage 48.22% 48.22%
=======================================
Files 8 8
Lines 846 846
Branches 191 191
=======================================
Hits 408 408
Misses 389 389
Partials 49 49 Continue to review full report at Codecov.
|
maxbischoff
approved these changes
Aug 4, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The main idea of this PR is to simplify the Dockerfile build and only use a single Dockerfile for both
illuminatioandilluminatio-runner.