Skip to content
This repository has been archived by the owner on Jul 5, 2023. It is now read-only.

Fix nmap error in travis #119

Merged
merged 8 commits into from
Aug 20, 2020
Merged

Fix nmap error in travis #119

merged 8 commits into from
Aug 20, 2020

Conversation

johscheuer
Copy link
Contributor

No description provided.

@johscheuer johscheuer added bug Something isn't working cleanup labels Aug 18, 2020
@codecov
Copy link

codecov bot commented Aug 18, 2020 •
edited
Loading

Codecov Report

Merging #119 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #119   +/-   ##
=======================================
  Coverage   39.02%   39.02%           
=======================================
  Files          11       11           
  Lines        1330     1330           
  Branches      264      264           
=======================================
  Hits          519      519           
+ Misses        765      762    -3     
- Partials       46       49    +3
Impacted Files Coverage Δ
src/illuminatio/host.py 64.39% <0.00%> (ø)
src/illuminatio/illuminatio.py 0.00% <0.00%> (ø)
src/illuminatio/test_orchestrator.py 24.10% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e1c0b05...b40d07b. Read the comment docs.

@johscheuer
Copy link
Contributor Author

This was a fun bug which was solved the nsenter branch. Before the old pathlib was installed which somehow broke with Python 3.4+ funny that we didn't saw this issue earlier.

@johscheuer johscheuer marked this pull request as ready for review August 20, 2020 15:52
@johscheuer
Copy link
Contributor Author

I will squash the commits once LGTM

maxbischoff
maxbischoff reviewed Aug 20, 2020
View reviewed changes
Copy link
Member

@maxbischoff maxbischoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One questions, otherwise LGTM

@johscheuer johscheuer merged commit b1ab409 into inovex:master Aug 20, 2020
@johscheuer johscheuer deleted the fix-nmap-error branch August 20, 2020 16:18
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@maxbischoff maxbischoff maxbischoff approved these changes

Assignees
No one assigned
Labels
bug Something isn't working cleanup
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@johscheuer @maxbischoff