Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BoardEvent "ParticipantUpdated" sends too much information #4217

Open
BenedictHomuth opened this issue Jun 14, 2024 · 0 comments · May be fixed by #4246
Open

BoardEvent "ParticipantUpdated" sends too much information #4217

BenedictHomuth opened this issue Jun 14, 2024 · 0 comments · May be fixed by #4246

Comments

@BenedictHomuth
Copy link
Collaborator

BenedictHomuth commented Jun 14, 2024

The problem

For now, when a user updates his appearance (avatar), name or gets promoted from participant to moderator, a "ParticipantUpdated" event is used to sync those changes on all currently connected boards.

This general logic is fine, but the amount of data sent through the network can be improved – and would also make the event less bloated.

Therefore the event should be split in two:

  • One for the updates on a given board session (role, ready state, banned, etc.) – potentially "BoardSessionUpdated"
  • One for the updates of the account itself (avatar, name, etc.) – potentially "UserUpdated"

Screenshots

Current event:
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: In Progress
Development

Successfully merging a pull request may close this issue.

2 participants