-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: templates framework #4254
Open
Schwehn42
wants to merge
158
commits into
main
Choose a base branch
from
js/template-sessions-framework
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sessions-framework # Conflicts: # src/constants/style.scss # src/routes/NewBoard/NewBoard.scss
…sessions-framework # Conflicts: # src/constants/style.scss # src/routes/NewBoard/NewBoard.tsx
was changed with ad91da3
…sessions-framework
…sessions-framework
…sessions-framework
…sessions-framework
dev: legacy=false prod: legacy=true
# Conflicts: # src/routes/Boards/Legacy/LegacyNewBoard.tsx # src/store/features/view/types.ts # src/store/reducer/view.ts
The deployment to the dev cluster was successful. You can find the deployment here: https://4254.development.scrumlr.fra.ics.inovex.io Deployed Images
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Resolves #4201
Resolves #4253
Adds the framework for the new template page. This includes both the layout and some functionality (like routing).
After logging into scrumlr, users will now be redirected to the templates page.
Important
To see the changes, make sure the env var
REACT_APP_LEGACY_CREATE_BOARD
is set tofalse
.Right now, they default to
false
in dev env, andtrue
in prod env.This is so the different changes can be merged into main without affecting current use.
The page consists of the header and main section
Header section
Main section
Changelog
templates
andsessions
to routenew
Sessions
accordinglyUserPill
Switch
SearchBar
NewBoard
to a grid including the new components in header, and the views as Outletstyle.scss
TODO
Checklist
(Optional) Visual Changes
Show media