-
Notifications
You must be signed in to change notification settings - Fork 631
[CSL-2125] Migrating to GHC-8.2.2 and LTS-10.* #2327
Conversation
Nice. Depends on input-output-hk/stack2nix#84 |
|
6e588ba
to
4644c7c
Compare
Note: I've rebased on latest |
026c006
to
6661905
Compare
@gromakovsky I have the following error at the moment after running build script.
Could you try to build and tell do you have similar error? I'm using |
@chshersh I tried it locally and I don't have such problem.
|
But I am using stack-1.6.3. However, I don't see this difference matters. |
cd58193
to
1419c0f
Compare
Looks like it's not Though |
1419c0f
to
8805d57
Compare
@domenkozar Okay, I will try to do this again. |
fdd6987
to
d89d872
Compare
Ok, so Windows CI no longer hangs by timeout. Instead it has some linker errors. |
Appveyor error is same as CSL-2344 |
Seems like it was addressed in develop - rebase should solve it. |
f0e8796
to
23d289b
Compare
I rebased on recent develop but the error is still there 😞 |
We should also probably rename cardano-sl-wallet-new :/ |
Looks like something related to Appveyor CI and Maybe I can try again after that PR is merged. |
This allows to make stack.yaml a little bit shorter.
23d289b
to
d3e912b
Compare
Start your day with new GHC build error on Windows... The previous on Windows CI was fixed (probably) but now I see another error. I discovered this discussion: Relevant part:
Maybe it can help this issue somehow. |
I recommend renaming |
@domenkozar didn't help |
Is it possible to upgrade the urgency on this? @avieth spent hours debugging a concurrency issue only to find that its a known issue simonmar/async#81 that been fixed in the next LTS. |
@erikd I think we just need a hero to solve the conflicts and to please the CI (that's the hardest part). I think we would benefit from running We had a similar situation this summer which was resolved by painfully weeding out either unused deps or packages that has "unique reverse dependency" by which I mean those packages that, if removed, would cause transitively other packages to be removed 😁 . The linked PR should have an half-baked script I have used with success this summer. |
+1 - once deps are weeded out, we need to fix MAX_PATH on windows (which @georgeee and others tried to already tried fixing it) |
Closing in favor of #2745 |
Current blocking issue: paging file is too small error on Windows CI.
What's done:
stack.yaml
GitHubextra-deps
are rewritten using newstack-1.6.*
syntax (it madestack.yaml
a little shorter).extra-deps
because they are in LTS-10.6 snapshot.universum-1.1.0
,log-warper-1.8.10
andserokel-util-0.7.0
.perl
coloring of output is removed fromscripts/build/cardano-sl.sh
since GHC-8.2.2 has its own coloring.-Wsimplifiable-class-constraints
. Some of them were fixed by @gromakovsky. Others — supressed.Things to note regarding @serokell packages:
log-warper-1.8.10
contains fix for async exceptions (see PR use log-warper with important bug fix #2566)time-units
(and utility functions) were removed fromserokell-util
package becase @serokell has new, better and maintained package for time-safe units —o-clock
. This resulted in a lot of dirty hacks in code (like, bringingsec :: Int -> Microsecond
function at every module where it's needed). But migration fromtime-units
too-clock
is planned under CSL-2319.universum-1.1.0
brought a lot of new things (which are the reason for most updates). See all changes here. Most developers weren't satisfied with all design decisions inuniversum
. So here is the list of updates/improvements (it's supposed thatuniversum
will bring backwards incompatible changes almost never):universum
reexportsid
now (identity
as well for compatibility).putText
renamed toputTextLn
.ToList
type class. It's merged withContainer
.Element
is now an associated type family.head
,tail
,last
,init
work withNonEmpty
. UsesafeHead :: [a] -> Maybe a
if you need.elems
andkeys
functions (so you can't havekeys
andelems
variables).