[ADP-2102] Remove mentions of stack from documentation and code
#3671
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonathanknowles
approved these changes
Dec 22, 2022
| @@ -20,7 +20,7 @@ | |||
| # individually. For example, run step1 to set up a state directory for | |||
| # the old version, then try: | |||
| # stateDir=./debug /nix/store/...-launch-migration-test-v2019-12-16.sh step1 | |||
| # stack exec migration-test -- step2 launch --state-dir=./debug ... | |||
| # exec migration-test -- step2 launch --state-dir=./debug ... | |||
There was a problem hiding this comment.
Perhaps:
Suggested change
| # exec migration-test -- step2 launch --state-dir=./debug ... | |
| # cabal run migration-test -- step2 launch --state-dir=./debug ... |
There was a problem hiding this comment.
… except that we do not have a migration-test component in any of our .cabal files. 😅 It appears that these tests for database migration have never been ported to the Shelley era and are completely broken.
Fixing the database migration tests is out of scope for this pull request, so I would prefer to write something blatantly wrong rather than try to pretend that the command cabal run migration-test may have worked at some point.
Co-authored-by: Jonathan Knowles <[email protected]>
|
bors merge |
|
Build succeeded: |
WilliamKingNoel-Bot
pushed a commit
that referenced
this pull request
Dec 22, 2022
…cumentation and code r=HeinrichApfelmus a=HeinrichApfelmus ### Overview This pull request removes all substantial mentions of `stack` from the documentation and .nix code. This includes LICENSE README.md bors.toml cabal.project default.nix docker-compose.yml docs flake.lock flake.nix floskell.json hie-direnv.yaml lib nix prototypes reports scripts shell.nix specifications test touch.me.CI weeder.dhall Mentions of `stack2cabal.nix`. LICENSE README.md bors.toml cabal.project default.nix docker-compose.yml docs flake.lock flake.nix floskell.json hie-direnv.yaml lib nix prototypes reports scripts shell.nix specifications test touch.me.CI weeder.dhall Nix shells for use with `stack`. LICENSE README.md bors.toml cabal.project default.nix docker-compose.yml docs flake.lock flake.nix floskell.json hie-direnv.yaml lib nix prototypes reports scripts shell.nix specifications test touch.me.CI weeder.dhall Mentions of `stack.yaml` as canonical source of package dependencies. ### Comments LICENSE README.md bors.toml cabal.project default.nix docker-compose.yml docs flake.lock flake.nix floskell.json hie-direnv.yaml lib nix prototypes reports scripts shell.nix specifications test touch.me.CI weeder.dhall Searching for the string `stack` in the project folder no longer turns up substantial results. ### Issue Number ADP-2102 Co-authored-by: Heinrich Apfelmus <[email protected]> Source commit: e2749fb
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This pull request removes all substantial mentions of
stackfrom the documentation and .nix code. This includesstack2cabal.nix.stack.stack.yamlas canonical source of package dependencies.Comments
stackin the project folder no longer turns up substantial results.Issue Number
ADP-2102