Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve inbound-governor simulation validation #3288

Closed
2 tasks done
coot opened this issue Aug 4, 2021 · 1 comment · Fixed by #3479
Closed
2 tasks done

Improve inbound-governor simulation validation #3288

coot opened this issue Aug 4, 2021 · 1 comment · Fixed by #3479
Assignees
@coot
Labels
inbound-governor Issues / PRs related to inbound-governor testing

Comments

@coot
Copy link
Contributor

coot commented Aug 4, 2021 •
edited by bolt12
Loading

Implement the following validation functions for
Test.Ouroboros.Network.Server2 simulations:

  • check the inbound governor trace if the connection manager returns
    UnsupportedState (e.g. when it calls demotedToColdRemote). This can be
    seen in TrPromotedToWarmRemote, TrDemotedToColdRemote and
    TrWaitIdleRemote trace messages.

  • validate if all the transitions done by inbound governor are valid. This
    could be done the same way we validate connection manager transitions.
@coot coot added inbound-governor Issues / PRs related to inbound-governor networking testing labels Aug 4, 2021
@coot coot self-assigned this Aug 31, 2021
@coot coot mentioned this issue Sep 3, 2021
Merged
@coot coot added the peer2peer label Sep 20, 2021
@coot coot changed the title Improve simulation validation Improve inbound-governor simulation validation Sep 29, 2021
@coot
Copy link
Contributor Author

coot commented Sep 29, 2021

The second point was done in #3318.

@bolt12 bolt12 linked a pull request Nov 22, 2021 that will close this issue
Monadify assertions and trace them accordingly #3479
Merged
@bolt12 bolt12 closed this as completed Nov 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@coot coot

Labels
inbound-governor Issues / PRs related to inbound-governor testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Monadify assertions and trace them accordingly IntersectMBO/ouroboros-network
2 participants
@coot @bolt12