Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(specs): make environment specs managed attributes #220

Merged
merged 19 commits into from
Mar 21, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
19 commits
Select commit Hold shift + click to select a range
47a50c1
test: implement spec access smoke test
aar65537 Jan 19, 2024
84d170b
feat: implement specs as properties
aar65537 Jan 20, 2024
69aefba
feat: implement generic typevar ActionSpec on Environment
aar65537 Jan 20, 2024
7c2c628
docs: Remove NestedSpec from docstrings
aar65537 Jan 27, 2024
44e6837
feat(env): implement generic Observation typevar on Environment
aar65537 Jan 27, 2024
094831e
feat(wrappers): Update wrappers to inherit type hints from Environment
aar65537 Jan 30, 2024
732229b
feat(wrappers): Add types to wrapper unit tests
aar65537 Jan 30, 2024
bd73139
fix: remove duplicate TypeVar definitions
aar65537 Jan 30, 2024
7aac615
Merge branch 'main' into 98-spec-props
aar65537 Jan 30, 2024
77af200
feat(pacman): change pacman specs to properties
aar65537 Jan 30, 2024
e2d7e6a
Merge branch 'main' into 98-spec-props
aar65537 Mar 13, 2024
68282af
feat(wrappers): add typevars to autoreset wrappers
aar65537 Mar 13, 2024
d04c66d
feat(sokoban): change sokoban specs to properties
aar65537 Mar 13, 2024
fcb952f
feat: implement specs as cached properties
aar65537 Mar 13, 2024
1442e6d
Merge branch 'main' into 98-spec-props
aar65537 Mar 13, 2024
063b108
feat(flatpak): change flatpak specs to cached properties
aar65537 Mar 13, 2024
ed66bf3
fix: constrain types-requests version to <1.27 due to conflict with n…
aar65537 Mar 13, 2024
c3d6f60
Merge branch 'main' into 98-spec-props
sash-a Mar 20, 2024
a1aec4f
feat(sliding tile): change sliding tile specs to properties
aar65537 Mar 21, 2024
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -172,7 +172,7 @@ state, timestep = jax.jit(env.reset)(key)
env.render(state)

# Interact with the (jit-able) environment
action = env.action_spec().generate_value() # Action selection (dummy value here)
action = env.action_spec.generate_value() # Action selection (dummy value here)
state, timestep = jax.jit(env.step)(state, action) # Take a step and observe the next state and time step
```

Expand Down
2 changes: 1 addition & 1 deletion docs/guides/advanced_usage.md
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ env = AutoResetWrapper(env) # Automatically reset the environment when an ep

batch_size = 7
rollout_length = 5
num_actions = env.action_spec().num_values
num_actions = env.action_spec.num_values

random_key = jax.random.PRNGKey(0)
key1, key2 = jax.random.split(random_key)
Expand Down
4 changes: 2 additions & 2 deletions docs/guides/wrappers.md
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ env = jumanji.make("Snake-6x6-v0")
dm_env = jumanji.wrappers.JumanjiToDMEnvWrapper(env)

timestep = dm_env.reset()
action = dm_env.action_spec().generate_value()
action = dm_env.action_spec.generate_value()
next_timestep = dm_env.step(action)
...
```
Expand Down Expand Up @@ -52,7 +52,7 @@ key = jax.random.PRNGKey(0)
state, timestep = env.reset(key)
print("New episode")
for i in range(100):
action = env.action_spec().generate_value() # Returns jnp.array(0) when using Snake.
action = env.action_spec.generate_value() # Returns jnp.array(0) when using Snake.
state, timestep = env.step(state, action)
if timestep.first():
print("New episode")
Expand Down
39 changes: 26 additions & 13 deletions jumanji/env.py
Original file line number Diff line number Diff line change
Expand Up @@ -17,13 +17,14 @@
from __future__ import annotations

import abc
from functools import cached_property
from typing import Any, Generic, Tuple, TypeVar

import chex
from typing_extensions import Protocol

from jumanji import specs
from jumanji.types import TimeStep
from jumanji.types import Observation, TimeStep


class StateProtocol(Protocol):
Expand All @@ -33,9 +34,10 @@ class StateProtocol(Protocol):


State = TypeVar("State", bound="StateProtocol")
ActionSpec = TypeVar("ActionSpec", bound=specs.Array)
clement-bonnet marked this conversation as resolved.
Show resolved Hide resolved


class Environment(abc.ABC, Generic[State]):
class Environment(abc.ABC, Generic[State, ActionSpec, Observation]):
"""Environment written in Jax that differs from the gym API to make the step and
reset functions jittable. The state contains all the dynamics and data needed to step
the environment, no computation stored in attributes of self.
Expand All @@ -45,8 +47,15 @@ class Environment(abc.ABC, Generic[State]):
def __repr__(self) -> str:
return "Environment."

def __init__(self) -> None:
"""Initialize environment."""
self.observation_spec
self.action_spec
self.reward_spec
self.discount_spec

@abc.abstractmethod
def reset(self, key: chex.PRNGKey) -> Tuple[State, TimeStep]:
def reset(self, key: chex.PRNGKey) -> Tuple[State, TimeStep[Observation]]:
"""Resets the environment to an initial state.

Args:
Expand All @@ -58,7 +67,9 @@ def reset(self, key: chex.PRNGKey) -> Tuple[State, TimeStep]:
"""

@abc.abstractmethod
def step(self, state: State, action: chex.Array) -> Tuple[State, TimeStep]:
def step(
self, state: State, action: chex.Array
) -> Tuple[State, TimeStep[Observation]]:
"""Run one timestep of the environment's dynamics.

Args:
Expand All @@ -71,33 +82,35 @@ def step(self, state: State, action: chex.Array) -> Tuple[State, TimeStep]:
"""

@abc.abstractmethod
def observation_spec(self) -> specs.Spec:
@cached_property
def observation_spec(self) -> specs.Spec[Observation]:
"""Returns the observation spec.

Returns:
observation_spec: a NestedSpec tree of spec.
observation_spec: a potentially nested `Spec` structure representing the observation.
"""

@abc.abstractmethod
def action_spec(self) -> specs.Spec:
@cached_property
def action_spec(self) -> ActionSpec:
"""Returns the action spec.

Returns:
action_spec: a NestedSpec tree of spec.
action_spec: a potentially nested `Spec` structure representing the action.
"""

@cached_property
def reward_spec(self) -> specs.Array:
"""Describes the reward returned by the environment. By default, this is assumed to be a
single float.
"""Returns the reward spec. By default, this is assumed to be a single float.

Returns:
reward_spec: a `specs.Array` spec.
"""
return specs.Array(shape=(), dtype=float, name="reward")

@cached_property
def discount_spec(self) -> specs.BoundedArray:
"""Describes the discount returned by the environment. By default, this is assumed to be a
single float between 0 and 1.
"""Returns the discount spec. By default, this is assumed to be a single float between 0 and 1.

Returns:
discount_spec: a `specs.BoundedArray` spec.
Expand All @@ -107,7 +120,7 @@ def discount_spec(self) -> specs.BoundedArray:
)

@property
def unwrapped(self) -> Environment:
def unwrapped(self) -> Environment[State, ActionSpec, Observation]:
return self

def render(self, state: State) -> Any:
Expand Down
8 changes: 6 additions & 2 deletions jumanji/environments/logic/game_2048/env.py
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@
# See the License for the specific language governing permissions and
# limitations under the License.

from functools import cached_property
from typing import Optional, Sequence, Tuple

import chex
Expand All @@ -29,7 +30,7 @@
from jumanji.viewer import Viewer


class Game2048(Environment[State]):
class Game2048(Environment[State, specs.DiscreteArray, Observation]):
"""Environment for the game 2048. The game consists of a board of size board_size x board_size
(4x4 by default) in which the player can take actions to move the tiles on the board up, down,
left, or right. The goal of the game is to combine tiles with the same number to create a tile
Expand Down Expand Up @@ -69,7 +70,7 @@ class Game2048(Environment[State]):
key = jax.random.PRNGKey(0)
state, timestep = jax.jit(env.reset)(key)
env.render(state)
action = env.action_spec().generate_value()
action = env.action_spec.generate_value()
state, timestep = jax.jit(env.step)(state, action)
env.render(state)
```
Expand All @@ -85,6 +86,7 @@ def __init__(
viewer: `Viewer` used for rendering. Defaults to `Game2048Viewer`.
"""
self.board_size = board_size
super().__init__()

# Create viewer used for rendering
self._viewer = viewer or Game2048Viewer("2048", board_size)
Expand All @@ -97,6 +99,7 @@ def __repr__(self) -> str:
"""
return f"2048 Game(board_size={self.board_size})"

@cached_property
def observation_spec(self) -> specs.Spec[Observation]:
"""Specifications of the observation of the `Game2048` environment.

Expand All @@ -122,6 +125,7 @@ def observation_spec(self) -> specs.Spec[Observation]:
),
)

@cached_property
def action_spec(self) -> specs.DiscreteArray:
"""Returns the action spec.

Expand Down
10 changes: 9 additions & 1 deletion jumanji/environments/logic/game_2048/env_test.py
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,10 @@

from jumanji.environments.logic.game_2048.env import Game2048
from jumanji.environments.logic.game_2048.types import Board, State
from jumanji.testing.env_not_smoke import check_env_does_not_smoke
from jumanji.testing.env_not_smoke import (
check_env_does_not_smoke,
check_env_specs_does_not_smoke,
)
from jumanji.testing.pytrees import assert_is_jax_array_tree
from jumanji.types import TimeStep

Expand Down Expand Up @@ -154,3 +157,8 @@ def test_game_2048__get_action_mask(game_2048: Game2048, board: Board) -> None:
def test_game_2048__does_not_smoke(game_2048: Game2048) -> None:
"""Test that we can run an episode without any errors."""
check_env_does_not_smoke(game_2048)


def test_game_2048__specs_does_not_smoke(game_2048: Game2048) -> None:
"""Test that we access specs without any errors."""
check_env_specs_does_not_smoke(game_2048)
8 changes: 6 additions & 2 deletions jumanji/environments/logic/graph_coloring/env.py
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@
# See the License for the specific language governing permissions and
# limitations under the License.

from functools import cached_property
from typing import Optional, Sequence, Tuple

import chex
Expand All @@ -33,7 +34,7 @@
from jumanji.viewer import Viewer


class GraphColoring(Environment[State]):
class GraphColoring(Environment[State, specs.DiscreteArray, Observation]):
"""Environment for the GraphColoring problem.
The problem is a combinatorial optimization task where the goal is
to assign a color to each vertex of a graph
Expand Down Expand Up @@ -76,7 +77,7 @@ class GraphColoring(Environment[State]):
key = jax.random.PRNGKey(0)
state, timestep = jax.jit(env.reset)(key)
env.render(state)
action = env.action_spec().generate_value()
action = env.action_spec.generate_value()
state, timestep = jax.jit(env.step)(state, action)
env.render(state)
```
Expand All @@ -100,6 +101,7 @@ def __init__(
num_nodes=20, edge_probability=0.8
)
self.num_nodes = self.generator.num_nodes
super().__init__()

# Create viewer used for rendering
self._env_viewer = viewer or GraphColoringViewer(name="GraphColoring")
Expand Down Expand Up @@ -206,6 +208,7 @@ def step(
)
return next_state, timestep

@cached_property
def observation_spec(self) -> specs.Spec[Observation]:
"""Returns the observation spec.

Expand Down Expand Up @@ -253,6 +256,7 @@ def observation_spec(self) -> specs.Spec[Observation]:
),
)

@cached_property
def action_spec(self) -> specs.DiscreteArray:
"""Specification of the action for the `GraphColoring` environment.

Expand Down
10 changes: 9 additions & 1 deletion jumanji/environments/logic/graph_coloring/env_test.py
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,10 @@

from jumanji.environments.logic.graph_coloring import GraphColoring
from jumanji.environments.logic.graph_coloring.types import State
from jumanji.testing.env_not_smoke import check_env_does_not_smoke
from jumanji.testing.env_not_smoke import (
check_env_does_not_smoke,
check_env_specs_does_not_smoke,
)
from jumanji.testing.pytrees import assert_is_jax_array_tree
from jumanji.types import TimeStep

Expand Down Expand Up @@ -90,3 +93,8 @@ def test_graph_coloring_get_action_mask(graph_coloring: GraphColoring) -> None:
def test_graph_coloring_does_not_smoke(graph_coloring: GraphColoring) -> None:
"""Test that we can run an episode without any errors."""
check_env_does_not_smoke(graph_coloring)


def test_graph_coloring_specs_does_not_smoke(graph_coloring: GraphColoring) -> None:
"""Test that we can access specs without any errors."""
check_env_specs_does_not_smoke(graph_coloring)
8 changes: 6 additions & 2 deletions jumanji/environments/logic/minesweeper/env.py
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@
# See the License for the specific language governing permissions and
# limitations under the License.

from functools import cached_property
from typing import Optional, Sequence, Tuple

import chex
Expand All @@ -36,7 +37,7 @@
from jumanji.viewer import Viewer


class Minesweeper(Environment[State]):
class Minesweeper(Environment[State, specs.MultiDiscreteArray, Observation]):
"""A JAX implementation of the minesweeper game.

- observation: `Observation`
Expand Down Expand Up @@ -81,7 +82,7 @@ class Minesweeper(Environment[State]):
key = jax.random.PRNGKey(0)
state, timestep = jax.jit(env.reset)(key)
env.render(state)
action = env.action_spec().generate_value()
action = env.action_spec.generate_value()
state, timestep = jax.jit(env.step)(state, action)
env.render(state)
```
Expand Down Expand Up @@ -127,6 +128,7 @@ def __init__(
self.num_rows = self.generator.num_rows
self.num_cols = self.generator.num_cols
self.num_mines = self.generator.num_mines
super().__init__()
self._viewer = viewer or MinesweeperViewer(
num_rows=self.num_rows, num_cols=self.num_cols
)
Expand Down Expand Up @@ -182,6 +184,7 @@ def step(
)
return next_state, next_timestep

@cached_property
def observation_spec(self) -> specs.Spec[Observation]:
"""Specifications of the observation of the `Minesweeper` environment.

Expand Down Expand Up @@ -229,6 +232,7 @@ def observation_spec(self) -> specs.Spec[Observation]:
step_count=step_count,
)

@cached_property
def action_spec(self) -> specs.MultiDiscreteArray:
"""Returns the action spec.
An action consists of the height and width of the square to be explored.
Expand Down
16 changes: 12 additions & 4 deletions jumanji/environments/logic/minesweeper/env_test.py
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,10 @@

from jumanji.environments.logic.minesweeper.env import Minesweeper
from jumanji.environments.logic.minesweeper.types import State
from jumanji.testing.env_not_smoke import check_env_does_not_smoke
from jumanji.testing.env_not_smoke import (
check_env_does_not_smoke,
check_env_specs_does_not_smoke,
)
from jumanji.testing.pytrees import assert_is_jax_array_tree
from jumanji.types import StepType, TimeStep

Expand Down Expand Up @@ -123,7 +126,7 @@ def test_minesweeper__step(minesweeper_env: Minesweeper) -> None:
key = jax.random.PRNGKey(0)
state, timestep = jax.jit(minesweeper_env.reset)(key)
# For this board, this action will be a non-mined square
action = minesweeper_env.action_spec().generate_value()
action = minesweeper_env.action_spec.generate_value()
next_state, next_timestep = step_fn(state, action)

# Check that the state has changed
Expand Down Expand Up @@ -154,6 +157,11 @@ def test_minesweeper__does_not_smoke(minesweeper_env: Minesweeper) -> None:
check_env_does_not_smoke(env=minesweeper_env)


def test_minesweeper__specs_does_not_smoke(minesweeper_env: Minesweeper) -> None:
"""Test that we can access specs without any errors."""
check_env_specs_does_not_smoke(minesweeper_env)


def test_minesweeper__render(
monkeypatch: pytest.MonkeyPatch, minesweeper_env: Minesweeper
) -> None:
Expand All @@ -162,7 +170,7 @@ def test_minesweeper__render(
state, timestep = jax.jit(minesweeper_env.reset)(jax.random.PRNGKey(0))
minesweeper_env.render(state)
minesweeper_env.close()
action = minesweeper_env.action_spec().generate_value()
action = minesweeper_env.action_spec.generate_value()
state, timestep = jax.jit(minesweeper_env.step)(state, action)
minesweeper_env.render(state)
minesweeper_env.close()
Expand All @@ -171,7 +179,7 @@ def test_minesweeper__render(
def test_minesweeper__done_invalid_action(minesweeper_env: Minesweeper) -> None:
"""Test that the strict done signal is sent correctly"""
# Note that this action corresponds to not stepping on a mine
action = minesweeper_env.action_spec().generate_value()
action = minesweeper_env.action_spec.generate_value()
*_, episode_length = play_and_get_episode_stats(
env=minesweeper_env, actions=[action for _ in range(10)], time_limit=10
)
Expand Down
Loading
Loading