feat: added support for express v5 beta #1261
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aryamohanan
commented
Aug 7, 2024
| methods.concat('all').forEach(method => { | ||
| if (typeof express.Route.prototype[method] === 'function') { | ||
| shimmer.wrap(express.Route.prototype, method, shimHandlerRegistration); | ||
| } | ||
| }); | ||
| } | ||
| if (express.Router && express.Router.prototype) { |
There was a problem hiding this comment.
In express v5 beta, the routing logic has been refactored to use the router module instead of a locally defined one. The methods to capture uncaught errors are now on the prototype of express.Router. This ensures the code correctly wraps and intercepts the handle and use methods in Express 5 beta for error capturing.
reference expressjs/express@cec5780
kirrg001
requested changes
Aug 7, 2024
aryamohanan
force-pushed
the
express-5-beta
branch
from
7e69906
to
ffe9145
Compare
kirrg001
requested changes
Aug 8, 2024
packages/core/src/tracing/instrumentation/frameworks/express.js
Outdated
Show resolved
Hide resolved
packages/core/src/tracing/instrumentation/frameworks/express.js
Outdated
Show resolved
Hide resolved
aryamohanan
force-pushed
the
express-5-beta
branch
from
a6e6368
to
0edeb63
Compare
kirrg001
reviewed
Aug 8, 2024
packages/collector/test/tracing/frameworks/express_uncaught_errors/app.js
Show resolved
Hide resolved
kirrg001
approved these changes
Aug 8, 2024
There was a problem hiding this comment.
LGTM
I think this is good enough for now as we have proven that most of the use cases work.
Follow up tickets:
- Currency report (asap)
- Move test env to express 5 (no specific date. We will til v5 comes out)
- Add express v5 support when it comes out (same as 2.)
aryamohanan
force-pushed
the
express-5-beta
branch
from
0edeb63
to
68e05d1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Express has been preparing for a major release (v5) for some time now, and they have already released several beta versions, including 5.0.0-beta.3.
This PR is intended to add support for the latest express v5 beta version 5.0.0-beta.3.
More details are in #1249
refs INSTA-11745