added attributes to github_user and github_team data sources #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mootpt
commented
Jun 12, 2017
•
mootpt
commented
- updated go-github
- added gpg and ssh keys to github_user data source and members to github_team
- fixed issues with attributes using pointers instead of functions
- documented changes
added 3 commits
June 12, 2017 10:16
- Added gpg_keys and ssh_key list to github_user data source - Added members list to github_team data source
This was referenced Jun 12, 2017
Closed
|
Looks great! Do we need to change things anywhere else for the vendor update? |
|
@josephholsten nope. should be good to merge. |
|
Hi @mootpt This LGTM! Thanks for this :) P. |
jcudit
pushed a commit
that referenced
this pull request
Mar 25, 2020
Refactor the error catching logic and be explicit about checking for a nil pointer.
kfcampbell
pushed a commit
to kfcampbell/terraform-provider-github
that referenced
this pull request
Jul 26, 2022
added attributes to github_user and github_team data sources
kfcampbell
pushed a commit
to kfcampbell/terraform-provider-github
that referenced
this pull request
Jul 26, 2022
Refactor the error catching logic and be explicit about checking for a nil pointer.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.