r/github_branch_protection: Support enforce_admins, update branch protection #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tection - Updates `branch_protection` resource for the new pull_request_reviews. - Adds `enforce_admins` - Fixes crash on empty items - Updates and fixes tests ``` $ make testacc TEST=./github TESTARGS="-run=TestAccGithubBranchProtection_" ==> Checking that code complies with gofmt requirements... TF_ACC=1 go test ./github -v -run=TestAccGithubBranchProtection_ -timeout 120m === RUN TestAccGithubBranchProtection_basic --- PASS: TestAccGithubBranchProtection_basic (6.32s) === RUN TestAccGithubBranchProtection_emptyItems --- PASS: TestAccGithubBranchProtection_emptyItems (4.21s) === RUN TestAccGithubBranchProtection_importBasic --- PASS: TestAccGithubBranchProtection_importBasic (3.77s) PASS ok github.com/terraform-providers/terraform-provider-github/github 14.307s ```
grubernaut
changed the title
catsby
reviewed
Jul 5, 2017
This was referenced Jul 5, 2017
kfcampbell
pushed a commit
to kfcampbell/terraform-provider-github
that referenced
this pull request
Jul 26, 2022
…-enforce-admins r/github_branch_protection: Support enforce_admins, update branch protection
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
branch_protectionresource for the new pull_request_reviews.enforce_adminsFixes: #18 #8