r/membership: Fix import crash on incorrect ID #72
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vancluever
requested review from
apparentlymart,
paddycarver,
radeksimko and
tombuildsstuff
An incorrect two-part ID supplied to github_membership during import results in a crash - this is because the import functionality is passing this directly to the Read function of the resource, for which IDs are programatically controlled and a panic there would be more telling of a much more serious error worthy of panicking over. This adds an internal validation function for two-part IDs, and wraps the resource's import functionality to use it to validate incoming IDs before passing them to Read.
vancluever
force-pushed
the
b-membership-import-crash
branch
from
6273c49
to
466389d
Compare
kfcampbell
pushed a commit
to kfcampbell/terraform-provider-github
that referenced
this pull request
Jul 26, 2022
…hip-import-crash r/membership: Fix import crash on incorrect ID
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An incorrect two-part ID supplied to
github_membershipduring importresults in a crash - this is because the import functionality is passing
this directly to the
Readfunction of the resource, for which IDs areprogramatically controlled and a panic there would be more telling of a
much more serious error worthy of panicking over.
This adds an internal validation function for two-part IDs, and wraps
the resource's import functionality to use it to validate incoming IDs
before passing them to
Read.