Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: improve examples and authentication info #801

Merged
merged 1 commit into from
May 25, 2021
Merged

docs: improve examples and authentication info #801

merged 1 commit into from
May 25, 2021

Conversation

loozhengyuan
Copy link
Contributor

@loozhengyuan loozhengyuan commented May 23, 2021

This PR improves the documentation examples by splitting into pre/post-0.12 code snippets so it will be clearer to new users on what the expected syntax should be. A new authentication section is added now that there is an option to choose between two authentication options. The arguments within the app_auth configuration block introduced in #753 is also expanded in detail.

Copy link
Contributor

@jcudit jcudit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Quality PR - thanks so much for this!

@jcudit jcudit merged commit 351b3c8 into integrations:master May 25, 2021
@loozhengyuan loozhengyuan deleted the patch-1 branch May 25, 2021 13:44
jcudit pushed a commit that referenced this pull request Jun 15, 2021
jcudit pushed a commit that referenced this pull request Jun 16, 2021
kfcampbell pushed a commit to kfcampbell/terraform-provider-github that referenced this pull request Jul 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants