(Fix #883) Additionally expose ipv4/6 cidrs in github_ip_ranges data source #884
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rymir
force-pushed
the
fix-issue-883-github-source-cidrs-ipv4-ipv6
branch
2 times, most recently
from
9a60870
to
942e3af
Compare
rymir
changed the title
…ranges data source Fixes integrations#883
rymir
force-pushed
the
fix-issue-883-github-source-cidrs-ipv4-ipv6
branch
from
942e3af
to
e52dcd3
Compare
bateller
approved these changes
Sep 1, 2021
jphuynh
approved these changes
Sep 1, 2021
jcudit
approved these changes
Sep 2, 2021
jphuynh
added a commit
to jphuynh/terraform-provider-github
that referenced
this pull request
Sep 2, 2021
Follow up on the PR (integrations#884) that introduced the *_ipv4/*_ipv6 attributes.
jcudit
pushed a commit
that referenced
this pull request
Sep 10, 2021
Follow up on the PR (#884) that introduced the *_ipv4/*_ipv6 attributes.
kfcampbell
pushed a commit
to kfcampbell/terraform-provider-github
that referenced
this pull request
Jul 26, 2022
…ranges data source (integrations#884) Fixes integrations#883
kfcampbell
pushed a commit
to kfcampbell/terraform-provider-github
that referenced
this pull request
Jul 26, 2022
…s#895) Follow up on the PR (integrations#884) that introduced the *_ipv4/*_ipv6 attributes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #883
https://api.github.com/meta recently changed and now includes both ipv4 and ipv6 cidrs
When integrating the
github_ip_rangesdata source with resources from other providers requiring cidrs to be specified separately (ipv4andipv6), you find yourself writing additional terraform logic to split them.ref. https://registry.terraform.io/providers/hashicorp/aws/latest/docs/resources/security_group_rule#ipv6_cidr_blocks
This pull request encapsulates the logic in the
github_ip_rangesdata source, by including additional_ipv4and_ipv6outputs - it maintains backwards compatibility intact as it preserves the original data source outputs too.