New resource github_repository_autolink_reference
#924
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrwacky42
reviewed
Oct 6, 2021
| } | ||
|
|
||
| resource "github_repository_autolink_reference" "autolink" { | ||
| depends_on = ["github_repository.off"] |
There was a problem hiding this comment.
Should this be
Suggested change
| depends_on = ["github_repository.off"] | |
| depends_on = ["github_repository.oof"] |
everywhere?
There was a problem hiding this comment.
oops, true. Good catch, has been updated with the latest commit
There was a problem hiding this comment.
I was about to start to implement this, then found your PR, so I thought I'd help with some code review... Hopefully the maintainers will bless it soon.
jcudit
approved these changes
Oct 17, 2021
entropitor
reviewed
Oct 18, 2021
Comment on lines
+22
to
+32
| Importer: &schema.ResourceImporter{ | ||
| State: func(d *schema.ResourceData, meta interface{}) ([]*schema.ResourceData, error) { | ||
| parts := strings.Split(d.Id(), "/") | ||
| if len(parts) != 2 { | ||
| return nil, fmt.Errorf("Invalid ID specified. Supplied ID must be written as <repository>/<autolink_reference_id>") | ||
| } | ||
| d.Set("repository", parts[0]) | ||
| d.SetId(parts[1]) | ||
| return []*schema.ResourceData{d}, nil | ||
| }, | ||
| }, |
There was a problem hiding this comment.
Should we allow to import by <repository>/<key-prefix> instead / as well? That's gonna make it much easier to import... Now the API must be called to get the id while everyone will have the key-prefix probably
kfcampbell
pushed a commit
to kfcampbell/terraform-provider-github
that referenced
this pull request
Jul 26, 2022
* Add resource github_repository_autolink_reference * Add resource to provider main file * Use correct resource name, thanks to @mrwacky42
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a new resource
github_repository_autolink_reference. Supports creation and deletion, in-place updates are not possible for autolink references afaik.This is my first time working on a Terraform provider, so sorry if I missed something :)
Fixes #285
Example usage: