Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

go.mod k8s.io updates and buildah fix #1783

Merged
merged 2 commits into from
Jul 23, 2024
Merged

go.mod k8s.io updates and buildah fix #1783

merged 2 commits into from
Jul 23, 2024

Conversation

mythi
Copy link
Contributor

@mythi mythi commented Jul 22, 2024 •
edited
Loading

Closes: #1780

@mythi
demo: use runc for buildah
34b3570 
Github crypto-perf/opae-nlb-demo image builds using buildah started
failing without a reason. While we could continue to debug the root
cause, let's admit the version is so old and a reasonable configuration
exists that makes the error go away: using BUILDAH_RUNTIME=runc just
like we use for the plugin images seems sufficient.

Signed-off-by: Mikko Ylinen <[email protected]>
@mythi mythi marked this pull request as ready for review July 23, 2024 08:01
@mythi mythi changed the title go.mod: upgrade to k8s.io v1.31-beta.0 and sigs.k8s.io/controller-run… go.mod k8s.io updates and buildah fix Jul 23, 2024
@mythi
Copy link
Contributor Author

mythi commented Jul 23, 2024

@eero-t are you fine with the suggested buildah fix?

@hj-johannes-lee PTAL and merge if ok

@eero-t
Copy link
Contributor

eero-t commented Jul 23, 2024

@eero-t are you fine with the suggested buildah fix?

Yes. It would still be nice to know what's the root cause, but in the meanwhile it's acceptable workaround.

(Cannot say anything about the other changes though, so approval needs to come from somebody else.)

@mythi
Copy link
Contributor Author

mythi commented Jul 23, 2024 •
edited by eero-t
Loading

:+1 FWIW, my host dmesg shows something that looks related: [55853.131352] audit: type=1326 audit(1721716790.685:552): auid=1001 uid=1001 gid=1002 ses=20 subj=unconfined pid=317640 comm="tar" exe="/usr/bin/tar" sig=0 arch=c000003e syscall=452 compat=0 ip=0x78a577c8fe8e code=0x50000

Does the container have any apt configs that would cause apt install to avoid calling that syscall? See: opencontainers/runc#2517 (comment)

@hj-johannes-lee
Copy link
Contributor

unfortunately not enough authority to merge it.

@hj-johannes-lee hj-johannes-lee merged commit a64b336 into intel:main Jul 23, 2024
73 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hj-johannes-lee hj-johannes-lee hj-johannes-lee approved these changes

@kad kad Awaiting requested review from kad kad is a code owner

@bart0sh bart0sh Awaiting requested review from bart0sh bart0sh is a code owner

@tkatila tkatila Awaiting requested review from tkatila tkatila is a code owner

@ozhuraki ozhuraki Awaiting requested review from ozhuraki ozhuraki is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mythi @eero-t @hj-johannes-lee