Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SYCL][COMPAT] Add a free function version of has_capability_or_fail #15717

Open
wants to merge 3 commits into
base: sycl
Choose a base branch
from

Conversation

zhiweij1
Copy link

Signed-off-by: Jiang, Zhiwei [email protected]

Signed-off-by: Jiang, Zhiwei <[email protected]>
Copy link

@ziranzha ziranzha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@tomflinda tomflinda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zhiweij1
Copy link
Author

Hi @Alcpz, I moved the definition of has_capability_or_fail() to before the device_ext class (b5a2593) to fix the compile fail in CI. Now CI has passed. Can this PR be merged?

@Alcpz
Copy link
Contributor

Alcpz commented Oct 17, 2024

@zhiweij1 Yes. I am fine with that.
We don´t have rights to merge PRs into DPC++, in order to merge stuff, please ping the intel/llvm-gatekeepers group. As long as you have the approvals and CI passes, they will merge with no issues.

@Alcpz
Copy link
Contributor

Alcpz commented Oct 17, 2024

@intel/llvm-gatekeepers This PR is ready for merging. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants