Skip to content
This repository has been archived by the owner on Oct 15, 2024. It is now read-only.

feat(action): strip component prefix from tag #7

Merged
merged 1 commit into from
Nov 16, 2021

Conversation

alejandrogr
Copy link
Contributor

Motivation

When creating a component tag, that tag is prefixed with a component-prefix. When we use this tag (for updating a version file or when we return the created tag from the action) may be useful to use it without the component prefix.

closes #6

@alejandrogr
Copy link
Contributor Author

I don't like how the test are approached in run.test.js. IMHO in those test we must mock all the modules (tags, branches, components...) and move the test in the run.test.js to the corresponding modules.

Anyway, I preferred to leave it as it is and put the test here so as not to get into a bigger refactor. We can add a new issue to make this refactor

@alejandrogr alejandrogr merged commit 637ccd9 into main Nov 16, 2021
@alejandrogr alejandrogr deleted the feature/strip-component-prefix-from-version-files branch November 16, 2021 12:46
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Component prefix needs to be removed when updating version files
3 participants