Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Presenting arrays/collections of objects doesn't work unless the entity class is explicitly passed into present #305

Closed
brandonweiss opened this issue Jan 5, 2013 · 4 comments

Comments

@brandonweiss
Copy link
Contributor

Presenting a collection of objects works if the entity class is explicitly passed into present. But if the entity class is set via represents or auto-detected by looking for an Entity constant inside of the object being presented then it breaks.

Is this intended? It's not what I was expecting.

@dblock
Copy link
Member

dblock commented Jan 5, 2013

This is not intended according to your description. A repro via a spec would be helpful (see endpoint_spec.rb around lines 475 for similar examples). Please also note a recent fix for #304, it could be related.

@brandonweiss
Copy link
Contributor Author

Doh. I probably shouldn't have included the issue number in the pull request title.

@dblock
Copy link
Member

dblock commented Jan 7, 2013

That doesn't matter :) But you do want to update CHANGELOG, please. I'll take a close look at this soon.

@brandonweiss
Copy link
Contributor Author

Ah yes. K, updated.

@dblock dblock closed this as completed in 42e29da Jan 7, 2013
dblock added a commit that referenced this issue Jan 7, 2013
Fix #305: presenting arrays of objects when the entity class isn't explicitly passed into present
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants