Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deposit: add missing fields to record deserializer #1838

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

rekt-hard
Copy link
Contributor

❤️ Thank you for your contribution!

Description

Add fields present in the response to record deserializer in the UI.
Added fields created, updated, revision_id

Two additional fields are part of the response but not part of the deserializer:

  • is_draft: since the context is the deposit page, it should be clear we are dealing with a draft.
  • expires_at: not relevant for a draft
    Could still add these two fields just to be complete.

Checklist

Ticks in all boxes and 🟢 on all GitHub actions status checks are required to merge:

Frontend

Reminder

By using GitHub, you have already agreed to the GitHub’s Terms of Service including that:

  1. You license your contribution under the same terms as the current repository’s license.
  2. You agree that you have the right to license your contribution under the current repository’s license.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants