-
Notifications
You must be signed in to change notification settings - Fork 202
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Exit code not properly returned when using steps #760
Labels
bug
Something isn't working
Comments
bvoq
changed the title
Bug: Exit code not properly returned when using steps
fix: Exit code not properly returned when using steps
Sep 23, 2024
This is a duplicate of #527 |
Ok thanks, I wasn't sure if I needed to file a new issue. |
Ah, this is actually not a duplicate, I'm re-opening this one. |
@jessicatarra could you maybe have a look at this one? :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Is there an existing issue for this?
Version
6.1.0
Description
Adding the following step will lead to a zero exit code, even when the test is supposed to fail.
If you run
melos test
I would expect a non-zero exit code, however I get exit code 0.However, if you run
melos exec -f --dir-exists=test -- flutter test
directly, you will get exit code 1.Steps to reproduce
Add any failing test to your project.
Then add the above script to
melos.yaml
.Then run
melos test
which should throw a non-zero exit code.Expected behavior
I would expect a non-zero exit code but I get a zero exit code.
Screenshots
No response
Additional context and comments
This was tested on macOS but I don't think it's platform specific.
The text was updated successfully, but these errors were encountered: