Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Exit code not properly returned when using steps #760

Open
1 task done
bvoq opened this issue Sep 23, 2024 · 4 comments
Open
1 task done

fix: Exit code not properly returned when using steps #760

bvoq opened this issue Sep 23, 2024 · 4 comments
Labels
bug Something isn't working

Comments

@bvoq
Copy link

bvoq commented Sep 23, 2024

Is there an existing issue for this?

  • I have searched the existing issues.

Version

6.1.0

Description

Adding the following step will lead to a zero exit code, even when the test is supposed to fail.

scripts:
  test:
    steps:
      - melos exec -f --dir-exists=test -- flutter test

If you run melos test I would expect a non-zero exit code, however I get exit code 0.
However, if you run melos exec -f --dir-exists=test -- flutter test directly, you will get exit code 1.

Steps to reproduce

Add any failing test to your project.
Then add the above script to melos.yaml.
Then run melos test which should throw a non-zero exit code.

Expected behavior

I would expect a non-zero exit code but I get a zero exit code.

Screenshots

No response

Additional context and comments

This was tested on macOS but I don't think it's platform specific.

@bvoq bvoq added the bug Something isn't working label Sep 23, 2024
@bvoq bvoq changed the title Bug: Exit code not properly returned when using steps fix: Exit code not properly returned when using steps Sep 23, 2024
@spydon
Copy link
Collaborator

spydon commented Sep 23, 2024

This is a duplicate of #527
Which you also commented on...

@spydon spydon closed this as not planned Won't fix, can't repro, duplicate, stale Sep 23, 2024
@bvoq
Copy link
Author

bvoq commented Sep 23, 2024

This is a duplicate of #527 Which you also commented on...

Ok thanks, I wasn't sure if I needed to file a new issue.
Thanks for maintaining this cool tool :-)

@spydon
Copy link
Collaborator

spydon commented Sep 24, 2024

Ah, this is actually not a duplicate, I'm re-opening this one.

@spydon spydon reopened this Sep 24, 2024
@spydon
Copy link
Collaborator

spydon commented Sep 24, 2024

@jessicatarra could you maybe have a look at this one? :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants