Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(installer): Add max python version to Windows installer #6865

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

aluhrs13
Copy link
Contributor

Summary

When running with Python 3.12, you get an obvious, but ugly error:

Looking in indexes: https://pypi.org/simple, https://download.pytorch.org/whl/cu121
ERROR: Ignored the following versions that require a different python version: 2.2.4.5 Requires-Python <3.11,>=3.9; 2.2.4.6 Requires-Python <3.11,>=3.9; 2.2.4.7 Requires-Python <3.11,>=3.9; 2.2.5 Requires-Python <3.11,>=3.9; 2.3.0 Requires-Python <3.11,>=3.9; 2.3.0a0 Requires-Python <3.11,>=3.9; 2.3.0a1 Requires-Python <3.11,>=3.9; 2.3.0a2 Requires-Python <3.11,>=3.9; 2.3.0a3 Requires-Python <3.11,>=3.9; 2.3.0rc3 Requires-Python <3.11,>=3.9; 2.3.0rc4 Requires-Python <3.11,>=3.9; 2.3.0rc5 Requires-Python <3.11,>=3.9; 2.3.0rc6 Requires-Python <3.11,>=3.9; 2.3.0rc7 Requires-Python <3.11,>=3.9; 2.3.1 Requires-Python <3.11,>=3.9; 2.3.1.post1 Requires-Python <3.11,>=3.9; 2.3.1.post2 Requires-Python <3.11,>=3.9; 2.3.1rc4 Requires-Python <3.11,>=3.9; 2.3.2 Requires-Python <3.11,>=3.9; 2.3.2.post1 Requires-Python <3.11,>=3.9; 2.3.3 Requires-Python <3.11,>=3.9; 2.3.3rc1 Requires-Python <3.11,>=3.9; 2.3.4 Requires-Python <3.11,>=3.9; 2.3.4.post1 Requires-Python <3.11,>=3.9; 2.3.4a0 Requires-Python <3.11,>=3.9; 2.3.4rc1 Requires-Python <3.11,>=3.9; 2.3.5 Requires-Python <3.11,>=3.9; 2.3.5.post1 Requires-Python <3.11,>=3.9; 2.3.5.post2 Requires-Python <3.11,>=3.9; 2.3.5rc1 Requires-Python <3.11,>=3.9; 3.0.0 Requires-Python <3.11,>=3.9; 3.0.1 Requires-Python <3.12,>=3.9; 3.0.1.post1 Requires-Python <3.12,>=3.9; 3.0.1.post2 Requires-Python <3.12,>=3.9; 3.0.1.post3 Requires-Python <3.12,>=3.9; 3.0.1rc1 Requires-Python <3.11,>=3.9; 3.0.1rc2 Requires-Python <3.12,>=3.9; 3.0.2 Requires-Python <3.12,>=3.9; 3.0.2.post1 Requires-Python <3.12,>=3.9; 3.0.2a1 Requires-Python <3.12,>=3.9; 3.0.2rc1 Requires-Python <3.12,>=3.9; 3.1.0 Requires-Python <3.12,>=3.9; 3.1.1 Requires-Python <3.12,>=3.9; 3.1.1rc1 Requires-Python <3.12,>=3.9; 3.2.0 Requires-Python <3.12,>=3.9; 3.3.0 Requires-Python <3.12,>=3.9; 3.3.0.post1 Requires-Python <3.12,>=3.9; 3.3.0.post2 Requires-Python <3.12,>=3.9; 3.3.0.post3 Requires-Python <3.12,>=3.9; 3.4.0 Requires-Python <3.12,>=3.10; 3.4.0.post1 Requires-Python <3.12,>=3.10; 3.4.0.post2 Requires-Python <3.12,>=3.10; 3.4.0rc2 Requires-Python <3.12,>=3.10; 3.4.0rc3 Requires-Python <3.12,>=3.10; 3.4.0rc4 Requires-Python <3.12,>=3.10; 3.5.0 Requires-Python <3.12,>=3.10; 3.5.0rc1 Requires-Python <3.12,>=3.10; 3.5.0rc2 Requires-Python <3.12,>=3.10; 3.5.0rc3 Requires-Python <3.12,>=3.10; 3.5.1 Requires-Python <3.12,>=3.10; 3.6.0 Requires-Python <3.12,>=3.10; 3.6.0rc1 Requires-Python <3.12,>=3.10; 3.6.0rc2 Requires-Python <3.12,>=3.10; 3.6.0rc3 Requires-Python <3.12,>=3.10; 3.6.0rc4 Requires-Python <3.12,>=3.10; 3.6.0rc5 Requires-Python <3.12,>=3.10; 3.6.0rc6 Requires-Python <3.12,>=3.10; 3.6.1 Requires-Python <3.12,>=3.10; 3.6.2 Requires-Python <3.12,>=3.10; 3.6.3 Requires-Python <3.12,>=3.10; 3.6.3rc1 Requires-Python <3.12,>=3.10; 3.7.0 Requires-Python <3.12,>=3.10; 4.0.0 Requires-Python <3.12,>=3.10; 4.0.0rc1 Requires-Python <3.12,>=3.10; 4.0.0rc2 Requires-Python <3.12,>=3.10; 4.0.0rc4 Requires-Python <3.12,>=3.10; 4.0.0rc5 Requires-Python <3.12,>=3.10; 4.0.0rc6 Requires-Python <3.12,>=3.10; 4.0.1 Requires-Python <3.12,>=3.10; 4.0.2 Requires-Python <3.12,>=3.10; 4.0.3 Requires-Python <3.12,>=3.10; 4.0.4 Requires-Python <3.12,>=3.10; 4.1.0 Requires-Python <3.12,>=3.10; 4.2.0 Requires-Python <3.12,>=3.10; 4.2.0a1 Requires-Python <3.12,>=3.10; 4.2.0a2 Requires-Python <3.12,>=3.10; 4.2.0a3 Requires-Python <3.12,>=3.10; 4.2.0a4 Requires-Python <3.12,>=3.10; 4.2.0b1 Requires-Python <3.12,>=3.10; 4.2.0b2 Requires-Python <3.12,>=3.10; 4.2.1 Requires-Python <3.12,>=3.10; 4.2.2 Requires-Python <3.12,>=3.10; 4.2.2.post1 Requires-Python <3.12,>=3.10; 4.2.3 Requires-Python <3.12,>=3.10; 4.2.4 Requires-Python <3.12,>=3.10; 4.2.5 Requires-Python <3.12,>=3.10; 4.2.6 Requires-Python <3.12,>=3.10; 4.2.6.post1 Requires-Python <3.12,>=3.10; 4.2.6a1 Requires-Python <3.12,>=3.10; 4.2.6rc1 Requires-Python <3.12,>=3.10; 4.2.7 Requires-Python <3.12,>=3.10; 4.2.7.post1 Requires-Python <3.12,>=3.10; 4.2.7rc1 Requires-Python <3.12,>=3.10; 4.2.8 Requires-Python <3.12,>=3.10; 4.2.8rc1 Requires-Python <3.12,>=3.10; 4.2.8rc2 Requires-Python <3.12,>=3.10; 4.2.9 Requires-Python <3.12,>=3.10; 4.2.9.dev10 Requires-Python <3.12,>=3.10; 4.2.9.dev11 Requires-Python <3.12,>=3.10; 4.2.9.dev12 Requires-Python <3.12,>=3.10; 4.2.9.dev20240823 Requires-Python <3.12,>=3.10; 4.2.9.dev20240824 Requires-Python <3.12,>=3.10; 4.2.9.dev3 Requires-Python <3.12,>=3.10; 4.2.9.dev4 Requires-Python <3.12,>=3.10; 4.2.9.dev5 Requires-Python <3.12,>=3.10; 4.2.9.dev6 Requires-Python <3.12,>=3.10; 4.2.9.dev7 Requires-Python <3.12,>=3.10; 4.2.9.dev8 Requires-Python <3.12,>=3.10; 4.2.9.dev9 Requires-Python <3.12,>=3.10; 4.2.9rc1 Requires-Python <3.12,>=3.10; 4.2.9rc2 Requires-Python <3.12,>=3.10; 5.0.0.dev13 Requires-Python <3.12,>=3.10; 5.0.0a1 Requires-Python <3.12,>=3.10; 5.0.0a2 Requires-Python <3.12,>=3.10; 5.0.0a3 Requires-Python <3.12,>=3.10; 5.0.0a4 Requires-Python <3.12,>=3.10; 5.0.0a5 Requires-Python <3.12,>=3.10; 5.0.0a6 Requires-Python <3.12,>=3.10; 5.0.0a7 Requires-Python <3.12,>=3.10
ERROR: Could not find a version that satisfies the requirement invokeai==5.0.0.a6 (from versions: none)
ERROR: No matching distribution found for invokeai==5.0.0.a6
Error: Unexpected exit code: 1
Command line: | 'C:\Users\aluhr\invokeai2\.venv\Scripts\pip.exe' install --require-virtualenv --force-reinstall --use-pep517 'invokeai[xformers,onnx-cuda]==5.0.0.a6' --extra-index-url https://download.pytorch.org/whl/cu121
Could not install InvokeAI. Please try downloading the latest version of the installer and install again.
Press any key to continue . . .

The most annoying part is the error happens after choosing everything, so you have to restart and do it all over again.

I think this is the right spot, not 100% sure.

Related Issues / Discussions

N/A - Can open one if needed.

QA Instructions

Tested with Python 3.9, 3.10, 3.11, and 3.12 by manually modifying my install.bat, wasn't sure about the *.bat.in thing, so I'm kinda guessing this is the right file to change.

Checklist

  • The PR has a short but descriptive title, suitable for a changelog
  • Tests added / updated (if applicable)
  • Documentation added / updated (if applicable)

@github-actions github-actions bot added the installer PRs that change the installer label Sep 16, 2024
@hipsterusername
Copy link
Member

Thanks @aluhrs13! This looks reasonable to me. Going to align on our plans re: 3.12 support and then incorporate.

Appreciate you helping boyscout things as you run into them - 🫡

Copy link
Member

@hipsterusername hipsterusername left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this (and apologies for the delay - sprint to 5.0 was hectic!)

After looking at this, I think the messaging here might be more clear if we tell the user they need 3.10 or 3.11 major versions. (vs "You need 3.11 but have 3.12")

Can we update the message to make this a bit clearer for end user?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
installer PRs that change the installer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants