misc(ui): image/asset tab tooltips, icon to rename board, getting started text #7067
Conversation
maryhipp
requested review from
psychedelicious,
blessedcoolant and
hipsterusername
as code owners
| {isHovering && ( | ||
| <IconButton | ||
| aria-label="edit name" | ||
| icon={<PiPencilBold />} | ||
| size="sm" | ||
| variant="ghost" | ||
| onClick={isEditing.setTrue} | ||
| /> | ||
| )} |
There was a problem hiding this comment.
Why is this needed? You can click the board title to edit it. Maybe the trigger to edit a board title should be a single click instead, would that not serve the need better than adding more buttons?
There was a problem hiding this comment.
Also this introduces a race condition (ish) where the icon doesn't disappear.
Screen.Recording.2024-10-09.at.6.55.56.am.mov
There was a problem hiding this comment.
Ok, I think there's just a typo in the PR description - mentions right-click but it actually means double-click, all good. I'll tidy up the minor issues I've mentioned in a followup or you can if you want
| > | ||
| {localTitle} | ||
| </Text> | ||
| <Flex alignItems="center" gap={1} onMouseOver={handleMouseOver} onMouseOut={handleMouseOut}> |
There was a problem hiding this comment.
This gap is a bit too small.
There was a problem hiding this comment.
| <Flex alignItems="center" gap={1} onMouseOver={handleMouseOver} onMouseOut={handleMouseOut}> | |
| <Flex alignItems="center" gap={3} onMouseOver={handleMouseOver} onMouseOut={handleMouseOut}> |
| <IconButton | ||
| aria-label="edit name" | ||
| icon={<PiPencilBold />} | ||
| size="sm" | ||
| variant="ghost" | ||
| onClick={isEditing.setTrue} | ||
| /> |
There was a problem hiding this comment.
variant="link" with alignSelf="stretch" looks better here (and no need to change the gap bc its kinda built-in to the button)
Summary
Misc UI:
Related Issues / Discussions
QA Instructions
Merge Plan
Checklist