Remove unneeded poll flags #46
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
According to poll(2) POLLERR and POLLHUP are are meaningless in the events field, and will be set in the revents field whenever the corresponding condition is true. So there is no need to register for these events. POLLPRI means there is urgent data to read. This can be read using the MSG_OOB flag, but manhole-cli does not use this feature, so there is no need to wait for this event.
|
Hey there, welcome back! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to poll(2) POLLERR and POLLHUP are are meaningless in the
events field, and will be set in the revents field whenever the
corresponding condition is true. So there is no need to register for
these events.
POLLPRI means there is urgent data to read. This can be read using the
MSG_OOB flag, but manhole-cli does not use this feature, so there is no
need to wait for this event.