Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(ios): remove allowFileAccessFromFileURLs preference call #6414

Merged
merged 1 commit into from
Mar 21, 2023

Conversation

jcesarmobile
Copy link
Member

allowFileAccessFromFileURLs is a non documented preference that can cause security warnings
it allows to load file:// urls in the WKWebView, but Capacitor uses custom schemes for serving the local files and provides a helper to convert any file:// url to a capacitor://localhost url, so the preference shouldn't be needed anymore, and if anybody is using it, should move to the capacitor://localhost urls

closes #6131

Copy link
Contributor

@markemer markemer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, this isn't guaranteed to stick around and if Apple's having a bad day they might even reject and app with it, although, I doubt it. Seems like we're using the proper alternative anyway.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

improvement: re-evaluate WebView's "allowFileAccessFromFileURLs" flag on iOS
3 participants