feat: retain multiple calls per event until consumed #6419
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
theproducer
requested review from
markemer,
jcesarmobile,
ItsChaceD,
IT-MikeS and
giralte-ionic
giralte-ionic
approved these changes
Mar 27, 2023
jcesarmobile
requested changes
Mar 27, 2023
There was a problem hiding this comment.
Since we are now retaining multiple events, and that can cause a delay on the execution, if a new event gets triggered while the events are being forwarded to javascript, that can cause race conditions and some events might be lost.
I think the code should create a copy of the retained event array and null the original one right away and then use the for on the copy array, so if new events happen during the for, the original array is null again and can get the new events.
jcesarmobile
approved these changes
Mar 31, 2023
markemer
pushed a commit
that referenced
this pull request
Apr 17, 2023
Co-authored-by: jcesarmobile <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for retaining multiple calls per event on iOS and Android.
closes: #5967