fix(item): form validation caret color renders correctly #25725
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request checklist
Please check if your PR fulfills the following requirements:
ionic-docs
repo, in a separate PR. See the contributing guide for details.npm run build
) was run locally and any changes were pushednpm run lint
) has passed locally and any fixes were made for failuresPull request type
Please check the type of change your PR introduces:
What is the current behavior?
Issue URL: resolves #25719
When simplifying the code for the input highlights/caret color in 5ca2ce9, I accidentally made the caret color apply to both iOS and MD modes. This behavior was added to align with the MD spec (https://material.io/components/text-fields), so it should only be available on MD mode.
Additionally, the usage of
--highlight-color-focused
was incorrect. We should use--highlight-background
as the value of that will be set to--highlight-color-focused
when the input is focused. In other words, we don't need to reference the var directly.What is the new behavior?
item.scss
was always overriding the incorrect code initem.md.scss
.Does this introduce a breaking change?
Other information