Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(datetime): next and previous buttons have correct labels #25845

Merged
merged 2 commits into from
Aug 29, 2022
Merged

Conversation

liamdebeasi
Copy link
Contributor

@liamdebeasi liamdebeasi commented Aug 29, 2022

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
    • Some docs updates need to be made in the ionic-docs repo, in a separate PR. See the contributing guide for details.
  • Build (npm run build) was run locally and any changes were pushed
  • Lint (npm run lint) has passed locally and any fixes were made for failures

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Issue URL: resolves #25844

What is the new behavior?

  • Narrators no longer read the icon aria-label. Instead, they read the custom "previous month" or "next month" labels we have assigned to the buttons.

Does this introduce a breaking change?

  • Yes
  • No

Other information

@github-actions github-actions bot added the package: core @ionic/core package label Aug 29, 2022
@liamdebeasi liamdebeasi marked this pull request as ready for review August 29, 2022 13:27
@liamdebeasi liamdebeasi requested a review from a team as a code owner August 29, 2022 13:27
@iamandersonp
Copy link

This fix will add the correct aria-labels but only for a english screen reader, if you have multilingual aplication it wont translate. The months and the days in calendar are translated via locale (or at least with the locale the screen reader says the days and monts in correct language)

@liamdebeasi
Copy link
Contributor Author

That capability is not built into ion-datetime. If you would like to see support for that added I recommend opening a Feature Request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package: core @ionic/core package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: ion-datetime incorrect aria-description for previous and next mount
3 participants