This repository has been archived by the owner on May 4, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 187
Multiple input devices problem in scrollView #37
Labels
Comments
From @norami on January 10, 2017 16:41 By some investigation, I found that this problem is specific to scrollView.js. In sliderView.js and tap.js the combination use of both of mouse and touch device is explicitly allowed. Behaviour of scrollView.js seems to be not preferable in the point of standardization of code. |
From @norami on January 10, 2017 17:11 More simple and standardized solution is shown in the commit above. |
I seemed to send PR to a wrong repository. |
norami
added a commit
to norami/ionic-v1
that referenced
this issue
Jan 16, 2017
In scrollView, combination use of mouse and touch device is disabled inappropriately, while it is enabled in the other components. This commit fixes the problem. ionic-team#37
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
From @norami on January 10, 2017 16:22
Ionic version: (check one with "x")
[x ] 1.x
[] 2.x
I'm submitting a ... (check one with "x")
[x] bug report
[ ] feature request
[ ] support request => Please do not submit support requests here, use one of these channels: https://forum.ionicframework.com/ or http://ionicworldwide.herokuapp.com/
Current behavior:
Some PCs enable multiple input devices. For example, Windows surface PCs enable both of touch device (physically screen) and mouse (physically touch panel or mouse). But ionic allow to use one kind of input device by the determination running on initialisation.
This leads very troubling behaviour. On windows surface PCs, user can click element with screen and touch panel while use cannot scroll element only with screen.
Expected behavior:
Like most applications, apps should enable multiple devices. In other words use should be able to use both of mouse (including touch panel) and touch device (screen of tablet).
Steps to reproduce:
With chrome debugger, you can reproduce easily this problem.
Reversal pattern goes well:
Related code:
I can use a monkey patch code shown in the lines below. This seems to work without any problem.
original code is line 5380 of:
https:/driftyco/ionic/blob/fded25c17864ac9bc37aedd9c1abf2295f4dca03/release/js/ionic.js
Copied from original issue: ionic-team/ionic-framework#9937
The text was updated successfully, but these errors were encountered: