feat(testing): allow to disable network error logging via 'logFailing…

…NetworkRequests' option (#5839)

* feat(testing): allow to disable network error logging via 'logFailingNetworkRequests' option

* keep current default behavior

src/testing/puppeteer/puppeteer-declarations.ts

@@ -18,8 +18,19 @@ export type PageCloseOptions = {
 export interface NewE2EPageOptions extends WaitForOptions {
  url?: string;
  html?: string;
+ /**
+ * If set to `true`, Stencil will throw an error if a console error occurs
+ */
  failOnConsoleError?: boolean;
+ /**
+ * If set to `true`, Stencil will throw an error if a network request fails
+ */
  failOnNetworkError?: boolean;
+ /**
+ * If set to `true`, Stencil will log failing network requests
+ * @default true
+ */
+ logFailingNetworkRequests?: boolean;
 }
 
 type Omit<T, K> = Pick<T, Exclude<keyof T, K>>;

src/testing/puppeteer/puppeteer-page.ts

@@ -115,6 +115,8 @@ export async function newE2EPage(opts: NewE2EPageOptions = {}): Promise<E2EPage>
 
  const failOnConsoleError = opts.failOnConsoleError === true;
  const failOnNetworkError = opts.failOnNetworkError === true;
+ const logFailingNetworkRequests =
+ typeof opts.logFailingNetworkRequests === 'boolean' ? opts.logFailingNetworkRequests : true;
 
  page.on('console', (ev) => {
  if (ev.type() === 'error') {
@@ -145,7 +147,7 @@ export async function newE2EPage(opts: NewE2EPageOptions = {}): Promise<E2EPage>
  });
  if (failOnNetworkError) {
  throw new Error(req.failure().errorText);
- } else {
+ } else if (logFailingNetworkRequests) {
  console.error('requestfailed', req.url());
  }
  });