Format stack frame as string #184
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closes iopipe#183 Signed-off-by: Michael Lavers <[email protected]>
Signed-off-by: Michael Lavers <[email protected]>
pselle
reviewed
Apr 6, 2018
| @@ -66,6 +66,7 @@ def test_erroring(mock_send_report, handler_that_errors, mock_context): | |||
|
|
|||
| assert iopipe.report.report['errors']['name'] == 'ValueError' | |||
| assert iopipe.report.report['errors']['message'] == 'Behold, a value error' | |||
| assert isinstance(iopipe.report.report['errors']['stack'], str) | |||
There was a problem hiding this comment.
Question: Did this test fail before you added your code that fixes it?
There was a problem hiding this comment.
No, it did not fail before. It is just an assertion that should be true.
There was a problem hiding this comment.
@pselle Did that answer your question?
pselle
approved these changes
Apr 9, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #183
Signed-off-by: Michael Lavers [email protected]