Logging Plugin #185
Merged
Logging Plugin #185
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@pselle @ewindisch This is ready to review. See the docs updates for usage details. |
ewindisch
reviewed
Apr 6, 2018
README.md
Outdated
| **Note:** This feature is still in beta. Want to try it out? Find us on [Slack](https://iopipe.now.sh). | ||
| @iopipe | ||
| def handler(event, context): | ||
| context.iopipe.log.info('Handler has started execution') |
There was a problem hiding this comment.
what if a user just does print() to stdout?
There was a problem hiding this comment.
The print() use case isn't currently handled.
There was a problem hiding this comment.
@ewindisch I added a redirect_stdout option.
Closes iopipe#178 Signed-off-by: Michael Lavers <[email protected]>
Signed-off-by: Michael Lavers <[email protected]>
Signed-off-by: Michael Lavers <[email protected]>
Signed-off-by: Michael Lavers <[email protected]>
Signed-off-by: Michael Lavers <[email protected]>
Signed-off-by: Michael Lavers <[email protected]>
Signed-off-by: Michael Lavers <[email protected]>
pselle
approved these changes
Apr 10, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #178
Signed-off-by: Michael Lavers [email protected]