Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add AES-CBC #41

Merged
merged 13 commits into from
May 12, 2022
Merged

Add AES-CBC #41

merged 13 commits into from
May 12, 2022

Conversation

l1h3r
Copy link
Contributor

@l1h3r l1h3r commented Jan 10, 2021

Description of change

Adds AES-CBC HMAC SHA2 algorithms defined in rfc7518 for JSON web tokens used in identity.rs

Type of change

  • Enhancement (a non-breaking change which adds functionality)

How the change has been tested

RFC test vectors

Change checklist

  • I have followed the contribution guidelines for this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@l1h3r l1h3r marked this pull request as draft January 11, 2021 07:33
@l1h3r l1h3r mentioned this pull request Mar 3, 2021
7 tasks
@l1h3r l1h3r marked this pull request as ready for review March 24, 2021 22:41
@nothingismagick
Copy link
Contributor

You know, this sort of thing REALLY seems like it should be a procedure in stronghold tbh. But I understand why you need it here.

@felsweg-iota felsweg-iota self-requested a review December 9, 2021 13:50
Copy link
Contributor

@felsweg-iota felsweg-iota left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Please let @Wollac approve as well.

Cargo.toml Outdated Show resolved Hide resolved
tests/ed25519.rs Outdated Show resolved Hide resolved
Copy link
Collaborator

@semenov-vladyslav semenov-vladyslav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good enough. But there's a few minor things to improve upon.

src/ciphers/aes_cbc.rs Show resolved Hide resolved
Cargo.toml Show resolved Hide resolved
Cargo.toml Show resolved Hide resolved
Copy link
Collaborator

@semenov-vladyslav semenov-vladyslav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use feature = "aes-gcm" in tests/aead.rs

tests/aead.rs Outdated Show resolved Hide resolved
tests/aead.rs Outdated Show resolved Hide resolved
@thibault-martinez thibault-martinez merged commit 8454c9b into dev May 12, 2022
@thibault-martinez thibault-martinez deleted the feat/aes-cbc branch May 12, 2022 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants