Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[blockdao] remove config.EVMNetworkID() #3452

Closed
3 tasks done
dustinxie opened this issue Jun 14, 2022 · 0 comments · Fixed by #3460
Closed
3 tasks done

[blockdao] remove config.EVMNetworkID() #3452

dustinxie opened this issue Jun 14, 2022 · 0 comments · Fixed by #3460
Assignees
@millken
Labels
refactor

Comments

@dustinxie
Copy link
Member

Description of the code refactor

solve the 2 TODO in commit 4be5188:

  1. 4be5188#diff-f082988255fcbe6608ac6f4488621d8d47ea8c032ca7235652a79c895a618636R45
  2. 4be5188#diff-3f4c4a2bbdc33fe76d0036bcaefaca49d48ddab45a3406eab8cfd0761da4b47fR266

pass the EVM network ID (from config) at time of newFileDAO(), feel free to discuss with me for the background and context of this task

Why is this needed

  • [] better/less memory usage
  • [] reduce running time
  • clean (easy-to-understand) data structure or algorithm
  • [] remove dead code
  • better code design or structure (like reduce complexity)
  • reduce/decouple dependencies between code modules
  • [] increase test coverage
  • [] better code readability
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@millken millken

Labels
refactor
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

remove config.EVMNetworkID() millken/iotex-core
2 participants
@millken @dustinxie