-
Notifications
You must be signed in to change notification settings - Fork 324
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
change commit block failure log level to error #2810
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2810 +/- ##
=======================================
Coverage 57.88% 57.88%
=======================================
Files 245 245
Lines 22437 22437
=======================================
Hits 12988 12988
Misses 7800 7800
Partials 1649 1649
Continue to review full report at Codecov.
|
blocksync/blocksync.go
Outdated
@@ -120,7 +120,7 @@ func (bs *blockSyncer) commitBlocks(blks []*peerBlock) bool { | |||
} | |||
bs.peerBlockList.Store(blk.pid, true) | |||
|
|||
log.L().Debug("failed to commit block", zap.Error(err)) | |||
log.L().Error("failed to commit block", zap.Error(err), zap.Error(err), zap.Uint64("height", blk.block.Height()), zap.String("peer", blk.pid)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
duplicate zap.Error(err)
?
* saving, switch to linux * tracing grpc api * saving, switch to linux * tracing grpc api * update tracer.go for test * small change * fix comments * Squashed commit of the following: commit 77a5a15 Author: dustinxie <[email protected]> Date: Tue Oct 5 23:34:52 2021 -0700 [api] add cache for ReadContract/State() (#2827) commit 7d9bf96 Author: Haaai <[email protected]> Date: Tue Oct 5 17:31:37 2021 -0700 bump Go to 1.17 (#2784) commit 09ef379 Author: dustinxie <[email protected]> Date: Tue Oct 5 16:46:49 2021 -0700 [ioctl] display chainID and encoding (#2820) commit c2eab8d Author: Haaai <[email protected]> Date: Tue Oct 5 15:45:45 2021 -0700 fix ioctl accountDelete test (#2825) commit 9489b57 Author: dustinxie <[email protected]> Date: Tue Oct 5 15:14:31 2021 -0700 remove unnecessary WithFeatureCtx() (#2823) commit 3933ae9 Author: dayuanc <[email protected]> Date: Tue Oct 5 07:40:32 2021 -0700 limit the pagination size for all API calls to 5000 -- 2781 (#2800) Co-authored-by: dayuanc <[email protected]> Co-authored-by: CoderZhi <[email protected]> Co-authored-by: Raullen Chai <[email protected]> commit 88d273d Author: dayuanc <[email protected]> Date: Mon Oct 4 10:51:54 2021 -0700 Add unit tests to cover the functions in action/signedaction.go (#2824) commit ebe895c Author: dustinxie <[email protected]> Date: Thu Sep 30 15:32:52 2021 -0700 [reward] extend foundation bonus (#2785) commit baa0a92 Author: CoderZhi <[email protected]> Date: Tue Sep 28 14:09:44 2021 -0700 Fix codecov (#2813) commit 84f06d3 Author: dayuanc <[email protected]> Date: Tue Sep 28 12:17:47 2021 -0700 reduce unnecessary logs for mainnet (#2808) * downgrade some unnecessary error and info logs * fix comments Co-authored-by: Raullen Chai <[email protected]> commit a245185 Author: dustinxie <[email protected]> Date: Mon Sep 27 15:27:59 2021 -0700 [evm] panic in AccessList API (#2816) commit 8eec1b7 Author: dustinxie <[email protected]> Date: Mon Sep 27 11:01:34 2021 -0700 set Jutland to activate at 10-11-2021 3pm PDT (#2812) Co-authored-by: Raullen Chai <[email protected]> commit e89be88 Author: CoderZhi <[email protected]> Date: Sat Sep 25 22:51:54 2021 -0700 set target height (#2807) Co-authored-by: dustinxie <[email protected]> commit dba4993 Author: CoderZhi <[email protected]> Date: Thu Sep 23 11:44:26 2021 -0700 change commit block failure log level to error (#2810) commit 0459a1f Author: mas walker <[email protected]> Date: Wed Sep 22 20:18:23 2021 +0800 unbound feature and version/height (#2768) * unbound feature and version/height Co-authored-by: Raullen Chai <[email protected]> commit c1cea44 Author: millken <[email protected]> Date: Tue Sep 21 06:31:57 2021 +0800 update circleci config, using golang 1.16.6 #2789 (#2791) Co-authored-by: dustinxie <[email protected]> commit f245109 Author: Dustin Xie <[email protected]> Date: Mon Sep 20 09:54:38 2021 -0700 [evm] enable opCall fix at Jutland height commit 3eea5b7 Author: Dustin Xie <[email protected]> Date: Mon Sep 20 12:11:36 2021 -0700 [evm] fix datacopy.json for TestIstanbul commit 0641db0 Author: CoderZhi <[email protected]> Date: Fri Sep 17 14:37:28 2021 -0700 [evm] fix snapshot bug (#2802) * fix snapshot bug * add unit test Co-authored-by: Raullen Chai <[email protected]> commit e0683e8 Author: Haaai <[email protected]> Date: Sat Sep 18 01:34:12 2021 +0800 add datacopy contract test (#2788) * add datacopy test * modify contract * remove debug log * update testdata * add attack bytecode * update datacopy.json * correct code format * remove printStore() in datacopy.sol * update contract test data Co-authored-by: dustinxie <[email protected]> commit 44e0a68 Author: Haaai <[email protected]> Date: Fri Sep 17 15:31:29 2021 +0800 Allow ioctl to show the list of actions for an account (#2750) * [ioctl] allow ioctl to show the list of actions for an account commit d10dabe Author: Haaai <[email protected]> Date: Fri Sep 17 12:08:33 2021 +0800 [api] fix gas estimation calc bug (#2786) * fixed gas estimation bug in api.go * Tracing (#2) * [reward] extend foundation bonus (#2785) * Add unit tests to cover the functions in action/signedaction.go (#2824) * limit the pagination size for all API calls to 5000 -- 2781 (#2800) Co-authored-by: dayuanc <[email protected]> Co-authored-by: CoderZhi <[email protected]> Co-authored-by: Raullen Chai <[email protected]> * remove unnecessary WithFeatureCtx() (#2823) * fix ioctl accountDelete test (#2825) * [ioctl] display chainID and encoding (#2820) * bump Go to 1.17 (#2784) * [api] add cache for ReadContract/State() (#2827) Co-authored-by: dustinxie <[email protected]> Co-authored-by: dayuanc <[email protected]> Co-authored-by: dayuanc <[email protected]> Co-authored-by: CoderZhi <[email protected]> Co-authored-by: Raullen Chai <[email protected]> Co-authored-by: Haaai <[email protected]> Co-authored-by: Raullen Chai <[email protected]> Co-authored-by: dustinxie <[email protected]> Co-authored-by: dayuanc <[email protected]> Co-authored-by: dayuanc <[email protected]> Co-authored-by: CoderZhi <[email protected]> Co-authored-by: Haaai <[email protected]>
with additional info