[api] Clean web3 code #3205
Merged
[api] Clean web3 code #3205
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #3205 +/- ##
==========================================
- Coverage 75.06% 74.95% -0.11%
==========================================
Files 228 228
Lines 21393 21366 -27
==========================================
- Hits 16058 16015 -43
- Misses 4483 4491 +8
- Partials 852 860 +8
Continue to review full report at Codecov.
|
CoderZhi
approved these changes
Mar 19, 2022
| } | ||
| return | ||
| } | ||
|
|
||
| func (svr *Web3Server) getBlockWithTransactions(blkMeta *iotextypes.BlockMeta, isDetailed bool) (blockObject, error) { |
There was a problem hiding this comment.
move this function back into web3server.go
dustinxie
reviewed
Mar 22, 2022
api/web3server_utils.go
Outdated
| gasLimit uint64 | ||
| value *big.Int | ||
| to string = "" | ||
| gasLimit uint64 = 0 |
dustinxie
reviewed
Mar 22, 2022
| @@ -224,43 +223,47 @@ func (svr *Web3Server) handleWeb3Req(web3Req gjson.Result) interface{} { | |||
| res, err = svr.getHashrate() | |||
| case "eth_getLogs": | |||
| var filter *filterObject | |||
| if filter, err = parseLogRequest(web3Req.Get("params")); err == nil { | |||
| filter, err = parseLogRequest(web3Req.Get("params")) | |||
| if err == nil { | |||
dustinxie
reviewed
Mar 22, 2022
| if err != nil { | ||
| return nil, err | ||
| func (svr *Web3Server) getBlockByNumber(in *gjson.Result) (interface{}, error) { | ||
| blkNum, isDetailed := in.Get("params.0"), in.Get("params.1") |
dustinxie
approved these changes
Mar 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
getStringAndBoolFromArrayandgetStringFromArrayare removed.