Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "[context] add public key size into ActionCtx (#3213)" #3219

Merged
merged 1 commit into from
Mar 21, 2022

Conversation

dustinxie
Copy link
Member

This reverts commit 2a55eed.

Description

It is verified in that all txs on chain have signature length = 65 (see func (sealed *SealedEnvelope) LoadProto(pbAct *iotextypes.Action). The original change is not needed

Type of change

  • Revert an earlier commit

How Has This Been Tested?

  • make test

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@dustinxie dustinxie requested a review from a team as a code owner March 21, 2022 19:57
@codecov
Copy link

codecov bot commented Mar 21, 2022

Codecov Report

Merging #3219 (7e8549c) into master (2a55eed) will decrease coverage by 0.02%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #3219      +/-   ##
==========================================
- Coverage   75.08%   75.06%   -0.03%     
==========================================
  Files         228      228              
  Lines       21399    21393       -6     
==========================================
- Hits        16067    16058       -9     
- Misses       4479     4483       +4     
+ Partials      853      852       -1     
Impacted Files Coverage Δ
action/protocol/context.go 37.81% <ø> (-3.46%) ⬇️
state/factory/workingset.go 72.06% <ø> (-0.10%) ⬇️
action/actctx.go 91.42% <100.00%> (+0.51%) ⬆️
action/protocol/account/transfer.go 86.30% <100.00%> (ø)
action/protocol/execution/protocol.go 42.10% <100.00%> (ø)
action/execution.go 76.53% <0.00%> (-5.11%) ⬇️
db/trie/mptrie/extensionnode.go 92.98% <0.00%> (+1.75%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2a55eed...7e8549c. Read the comment docs.

Copy link
Collaborator

@CoderZhi CoderZhi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can have a PR to modify it instead of reverting.

@dustinxie
Copy link
Member Author

We can have a PR to modify it instead of reverting.

yes, it will be PR 3096

@dustinxie dustinxie merged commit f85274e into iotexproject:master Mar 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants