Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[staking] clean up internal interface #3404

Merged
merged 2 commits into from
May 27, 2022
Merged

Conversation

dustinxie
Copy link
Member

Description

as title

Type of change

Please delete options that are not relevant.

  • Code refactor or improvement

How Has This Been Tested?

  • make test

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@dustinxie dustinxie requested a review from a team as a code owner May 20, 2022 17:20

func (csm *candSM) DelCandBucketIndex(addr address.Address, index uint64) error {
return csm.delBucketIndex(addr, _candIndex, index)
}
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

these func should go to candSR and candSM, and don't need to be exported

@codecov
Copy link

codecov bot commented May 20, 2022

Codecov Report

Merging #3404 (323d09a) into master (180ab52) will not change coverage.
The diff coverage is 90.90%.

@@           Coverage Diff           @@
##           master    #3404   +/-   ##
=======================================
  Coverage   75.32%   75.32%           
=======================================
  Files         236      236           
  Lines       21973    21973           
=======================================
  Hits        16551    16551           
  Misses       4530     4530           
  Partials      892      892           
Impacted Files Coverage Δ
action/protocol/staking/bucket_index.go 93.33% <ø> (-1.91%) ⬇️
action/protocol/staking/candidate_statereader.go 57.31% <66.66%> (+0.68%) ⬆️
action/protocol/staking/candidate_statemanager.go 97.22% <100.00%> (+0.16%) ⬆️
action/protocol/staking/handlers.go 74.83% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 180ab52...323d09a. Read the comment docs.

@dustinxie dustinxie merged commit a1bc494 into iotexproject:master May 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants