Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ioctl] Build hdwallet derive command line into new ioctl #3418
[ioctl] Build hdwallet derive command line into new ioctl #3418
Changes from 7 commits
ca74a4b
6f1fbe8
3c51320
899aa8b
d2ae909
0f77970
f3cb430
0a1fa1b
a56fa05
0c8f894
c4c4447
23aca4e
c6f16ee
78c2154
941bf73
10d72e2
8384ca3
af4ed34
cef0bd5
5c61230
f2df4c1
71a0a44
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why is it changed to client?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess you're talking about
HdwalletMnemonic
.The main reason is that we don't want to expose
hdwalletConfigFile
, so we add it inclient
struct, which makes all the related function also needs to be inside the client interface.Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.