Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[protocol] remove config.EVMNetworkID() from EVM/execution #3431

Merged
merged 1 commit into from
Jun 8, 2022

Conversation

dustinxie
Copy link
Member

Description

  1. global config.EVMNetworkID() is a work-around, the better solution is to use an EvmNetworkID at creation time, or pass it via context
  2. this is the 1st commit, more PR will come to handle other modules

Type of change

  • Code refactor or improvement

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@codecov
Copy link

codecov bot commented Jun 8, 2022

Codecov Report

Merging #3431 (c434717) into master (2e8ef35) will increase coverage by 0.00%.
The diff coverage is 75.00%.

@@           Coverage Diff           @@
##           master    #3431   +/-   ##
=======================================
  Coverage   75.15%   75.15%           
=======================================
  Files         236      236           
  Lines       22069    22070    +1     
=======================================
+ Hits        16586    16587    +1     
  Misses       4594     4594           
  Partials      889      889           
Impacted Files Coverage Δ
action/protocol/context.go 37.19% <ø> (ø)
action/protocol/execution/evm/evm.go 44.98% <75.00%> (+0.16%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2e8ef35...c434717. Read the comment docs.

@dustinxie dustinxie merged commit 7d66698 into iotexproject:master Jun 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants