[api] Remove ActionsByBlock() in coreService #3432
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #3432 +/- ##
==========================================
+ Coverage 75.13% 75.15% +0.02%
==========================================
Files 236 236
Lines 22077 22069 -8
==========================================
- Hits 16587 16586 -1
+ Misses 4598 4594 -4
+ Partials 892 889 -3
Continue to review full report at Codecov.
|
CoderZhi
approved these changes
Jun 5, 2022
dustinxie
reviewed
Jun 6, 2022
api/coreservice.go
Outdated
| // ActionsByBlock returns all actions in a block | ||
| func (core *coreService) ActionsByBlock(blkHash string, start uint64, count uint64) ([]*iotexapi.ActionInfo, error) { | ||
| // BlockByHash returns the block and its receipt | ||
| func (core *coreService) BlockByHash(blkHash string) (*block.Block, []*action.Receipt, error) { |
There was a problem hiding this comment.
can remove []*action.Receipt, see comment below
dustinxie
reviewed
Jun 6, 2022
api/coreservice.go
Outdated
| @@ -1051,7 +1025,7 @@ func (core *coreService) ActionsInBlockByHash(blkHash string) ([]action.SealedEn | |||
| if err != nil { | |||
| return nil, nil, errors.Wrap(ErrNotFound, err.Error()) | |||
| } | |||
| return blk.Actions, receipts, nil | |||
| return blk, receipts, nil | |||
There was a problem hiding this comment.
blk.Receipts = receipts
return blk, nil
dustinxie
reviewed
Jun 6, 2022
| @@ -185,6 +195,54 @@ func (svr *GRPCServer) GetActions(ctx context.Context, in *iotexapi.GetActionsRe | |||
| }, nil | |||
| } | |||
|
|
|||
| func actionsInBlock(blk *block.Block, receipts []*action.Receipt, start, count uint64) ([]*iotexapi.ActionInfo, error) { | |||
There was a problem hiding this comment.
can remove []*action.Receipt, see comment above
dustinxie
approved these changes
Jun 6, 2022
Liuhaai
force-pushed
the
removeActionsByBlock
branch
from
a76f178
to
5d0abb1
Compare
saitofun
pushed a commit
that referenced
this pull request
Jun 8, 2022
* remove ActionsByBlock() in coreService
saitofun
pushed a commit
that referenced
this pull request
Jun 9, 2022
* remove ActionsByBlock() in coreService
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Solve
TODOin the codebaseType of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Test Configuration:
Checklist: